From 6149f21cd6938ec711ace347ec54f63dcf69d4e4 Mon Sep 17 00:00:00 2001 From: Erik Grinaker Date: Thu, 1 Oct 2020 16:06:34 +0200 Subject: [PATCH] privval: allow passing options to NewSignerDialerEndpoint (#5434) (#5437) Required for #5291 to set timeouts for remote signers. --- CHANGELOG_PENDING.md | 2 ++ privval/signer_dialer_endpoint.go | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md index 402e0db20..78d13cf9a 100644 --- a/CHANGELOG_PENDING.md +++ b/CHANGELOG_PENDING.md @@ -24,5 +24,7 @@ Friendly reminder, we have a [bug bounty program](https://hackerone.com/tendermi - [config] \#5433 `statesync.rpc_servers` is now properly set when writing the configuration file (@erikgrinaker) +- [privval] \#5437 `NewSignerDialerEndpoint` can now be given `SignerServiceEndpointOption` (@erikgrinaker) + ### BUG FIXES diff --git a/privval/signer_dialer_endpoint.go b/privval/signer_dialer_endpoint.go index 7336f64be..bd98314b6 100644 --- a/privval/signer_dialer_endpoint.go +++ b/privval/signer_dialer_endpoint.go @@ -48,6 +48,7 @@ type SignerDialerEndpoint struct { func NewSignerDialerEndpoint( logger log.Logger, dialer SocketDialer, + options ...SignerServiceEndpointOption, ) *SignerDialerEndpoint { sd := &SignerDialerEndpoint{ @@ -56,6 +57,10 @@ func NewSignerDialerEndpoint( maxConnRetries: defaultMaxDialRetries, } + for _, optionFunc := range options { + optionFunc(sd) + } + sd.BaseService = *service.NewBaseService(logger, "SignerDialerEndpoint", sd) sd.signerEndpoint.timeoutReadWrite = defaultTimeoutReadWriteSeconds * time.Second