From 796688e7d7d9528c2bbba8ad8f846b28b69f058a Mon Sep 17 00:00:00 2001
From: Sam Kleinman <garen@tychoish.com>
Date: Wed, 15 Jun 2022 11:36:11 -0400
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
---
 internal/p2p/metrics.go                  |  1 -
 internal/p2p/peermanager_scoring_test.go | 11 +++--------
 internal/p2p/router.go                   |  4 ++--
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/internal/p2p/metrics.go b/internal/p2p/metrics.go
index 34f78f185..a267f12a0 100644
--- a/internal/p2p/metrics.go
+++ b/internal/p2p/metrics.go
@@ -28,7 +28,6 @@ var (
 type Metrics struct {
 	// Number of peers connected.
 	PeersConnected metrics.Gauge
-
 	// Nomber of peers in the peer store database.
 	PeersStored metrics.Gauge
 	// Number of inactive peers stored.
diff --git a/internal/p2p/peermanager_scoring_test.go b/internal/p2p/peermanager_scoring_test.go
index 36352beaf..1368bdf9c 100644
--- a/internal/p2p/peermanager_scoring_test.go
+++ b/internal/p2p/peermanager_scoring_test.go
@@ -115,14 +115,9 @@ func makeMockPeerStore(t *testing.T, peers ...peerInfo) *peerStore {
 func TestPeerRanking(t *testing.T) {
 	t.Run("InactiveSecond", func(t *testing.T) {
 		store := makeMockPeerStore(t,
-			peerInfo{
-				ID:       "second",
-				Inactive: true,
-			},
-			peerInfo{
-				ID:       "first",
-				Inactive: false,
-			})
+			peerInfo{ID: "second", Inactive: true},
+			peerInfo{ID: "first", Inactive: false},
+		)
 
 		ranked := store.Ranked()
 		if len(ranked) != 2 {
diff --git a/internal/p2p/router.go b/internal/p2p/router.go
index 1f6314fa1..4e15a3d2d 100644
--- a/internal/p2p/router.go
+++ b/internal/p2p/router.go
@@ -444,8 +444,8 @@ func (r *Router) filterPeersID(ctx context.Context, id types.NodeID) error {
 func (r *Router) dialSleep(ctx context.Context) {
 	if r.options.DialSleep == nil {
 		const (
-			maxDialerInterval = 500
-			minDialerInterval = 100
+			maxDialerInterval = 500  // ms
+			minDialerInterval = 100  // ms
 		)
 
 		// nolint:gosec // G404: Use of weak random number generator