mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-03 11:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

test/e2e: increase sign/propose tolerances (#6033)

Browse Source 
E2E tests often fail because validators miss signing or proposing blocks. Often this is because e.g. there's a lot of disruption in the network or it takes a long time to start up all the nodes.

This changes the test criteria to only check for 3 signed/proposed blocks, rather than a fraction of the expected blocks. This should be enough to catch most issues, apart from performance problems causing nodes to miss signing/proposing, but we may want separate tests for those sorts of things.
This commit is contained in:
Erik Grinaker
2021-02-02 13:43:08 +01:00
committed by Tess Rinearson
parent f009a1a731
commit 8788673a3e
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/e2e/tests/validator_test.go
View File

@@ -77,8 +77,12 @@ func TestValidator_Propose(t *testing.T) {
require.False(t, proposeCount == 0 && expectCount > 0,
"node did not propose any blocks (expected %v)", expectCount)
require.Less(t, expectCount-proposeCount, 5,
"validator missed proposing too many blocks (proposed %v out of %v)", proposeCount, expectCount)
if expectCount > 3 {
require.GreaterOrEqual(t, proposeCount, 3, "validator didn't propose even 3 blocks")
} else {
require.Equal(t, proposeCount, expectCount, "validator missed proposing blocks (proposed %v, expected %v)",
proposeCount, expectCount)
}
})
}
@@ -115,9 +119,13 @@ func TestValidator_Sign(t *testing.T) {
}
require.False(t, signCount == 0 && expectCount > 0,
"node did not sign any blocks (expected %v)", expectCount)
require.Less(t, float64(expectCount-signCount)/float64(expectCount), 0.5,
"validator missed signing too many blocks (signed %v out of %v)", signCount, expectCount)
"validator did not sign any blocks (expected %v)", expectCount)
if expectCount > 3 {
require.GreaterOrEqual(t, signCount, 3, "validator didn't sign even 3 blocks")
} else {
require.Equal(t, signCount, expectCount, "validator missed signing blocks (signed %v, expected %v)",
signCount, expectCount)
}
})
}