linting: fixup some stuffs

keys/cryptostore/holder.go

@@ -24,14 +24,15 @@ func New(coder Encoder, store keys.Storage, codec keys.Codec) Manager {
 	}
 }
 
+var _ keys.Signer = Manager{}
+var _ keys.Manager = Manager{}
+
 // exists just to make sure we fulfill the Signer interface
-// nolint [ megacheck, deadcode ]
 func (s Manager) assertSigner() keys.Signer {
 	return s
 }
 
 // exists just to make sure we fulfill the Manager interface
-// nolint [ megacheck, deadcode ]
 func (s Manager) assertKeyManager() keys.Manager {
 	return s
 }

keys/cryptostore/holder_test.go

@@ -144,7 +144,6 @@ func TestKeyManagement(t *testing.T) {
 // 	}
 // }
 
-// nolint: unparam
 func assertPassword(assert *assert.Assertions, cstore cryptostore.Manager, name, pass, badpass string) {
 	err := cstore.Update(name, badpass, pass)
 	assert.NotNil(err)

keys/server/helpers.go

@@ -6,7 +6,6 @@ Please read the README and godoc to see how to
 configure the server for your application.
 */
 
-// nolint: goimports
 package server
 
 import (

keys/server/keys.go

@@ -52,7 +52,6 @@ func (k Keys) GetKey(w http.ResponseWriter, r *http.Request) {
 	writeSuccess(w, &key)
 }
 
-// nolint: unparam
 func (k Keys) ListKeys(w http.ResponseWriter, r *http.Request) {
 
 	keys, err := k.manager.List()

keys/server/keys_test.go

@@ -120,7 +120,6 @@ func listKeys(h http.Handler) (keys.Infos, int, error) {
 	return data, rr.Code, err
 }
 
-// nolint: unparam
 func getKey(h http.Handler, name string) (*keys.Info, int, error) {
 	rr := httptest.NewRecorder()
 	req, err := http.NewRequest("GET", "/keys/"+name, nil)
@@ -138,7 +137,6 @@ func getKey(h http.Handler, name string) (*keys.Info, int, error) {
 	return &data, rr.Code, err
 }
 
-// nolint: unparam
 func createKey(h http.Handler, name, passphrase, algo string) (*types.CreateKeyResponse, int, error) {
 	rr := httptest.NewRecorder()
 	post := types.CreateKeyRequest{
@@ -167,7 +165,6 @@ func createKey(h http.Handler, name, passphrase, algo string) (*types.CreateKeyR
 	return data, rr.Code, err
 }
 
-// nolint: unparam
 func deleteKey(h http.Handler, name, passphrase string) (*types.ErrorResponse, int, error) {
 	rr := httptest.NewRecorder()
 	post := types.DeleteKeyRequest{

keys/storage/filestorage/main.go

@@ -42,8 +42,9 @@ func New(dir string) FileStore {
 	return FileStore{dir}
 }
 
+var _ keys.Storage = FileStore{}
+
 // assertStorage just makes sure we implement the proper Storage interface
-// nolint [ megacheck, deadcode ]
 func (s FileStore) assertStorage() keys.Storage {
 	return s
 }

keys/storage/memstorage/main.go

@@ -22,8 +22,9 @@ func New() MemStore {
 	return MemStore{}
 }
 
+var _ keys.Storage = MemStore{}
+
 // assertStorage just makes sure we implement the Storage interface
-// nolint [ megacheck, deadcode ]
 func (s MemStore) assertStorage() keys.Storage {
 	return s
 }

keys/wordlist/wordlist.go

@@ -6,7 +6,6 @@
 // keys/wordlist/spanish.txt
 // DO NOT EDIT!
 
-// nolint: goimports
 package wordlist
 
 import (