From 8bb7983c4c3f0956329539cf3b4951b389a42e26 Mon Sep 17 00:00:00 2001 From: Thane Thomson Date: Mon, 11 Apr 2022 21:08:30 -0400 Subject: [PATCH] Read lock consensus state mutex in test helper to avoid data race Signed-off-by: Thane Thomson --- internal/consensus/common_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/internal/consensus/common_test.go b/internal/consensus/common_test.go index b13d9c9d4..242bf5576 100644 --- a/internal/consensus/common_test.go +++ b/internal/consensus/common_test.go @@ -350,6 +350,8 @@ func validatePrecommit( require.True(t, bytes.Equal(vote.BlockID.Hash, votedBlockHash), "Expected precommit to be for proposal block") } + cs.mtx.RLock() + defer cs.mtx.RUnlock() if lockedBlockHash == nil { require.False(t, cs.LockedRound != lockRound || cs.LockedBlock != nil, "Expected to be locked on nil at round %d. Got locked at round %d with block %v",