mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-06 13:26:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

rpc: modify New* functions to return error (#4274)

Browse Source 
The New* client functions return an error instead
of panicking when the remote address is invalid.

Fixes #3953
This commit is contained in:
Peter Mrekaj
2020-01-07 07:07:03 +01:00
committed by Anton Kaliaev
parent 7be74c73b7
commit 8f5d58f32e
19 changed files with 156 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/tendermint/commands/debug/dump.go
View File

@@ -58,7 +58,10 @@ func dumpCmdHandler(_ *cobra.Command, args []string) error {
}
}
rpc := rpcclient.NewHTTP(nodeRPCAddr, "/websocket")
rpc, err := rpcclient.NewHTTP(nodeRPCAddr, "/websocket")
if err != nil {
return errors.Wrap(err, "failed to create new http client")
}
home := viper.GetString(cli.HomeFlag)
conf := cfg.DefaultConfig()

5
cmd/tendermint/commands/debug/kill.go
View File

@@ -44,7 +44,10 @@ func killCmdHandler(cmd *cobra.Command, args []string) error {
return errors.New("invalid output file")
}
rpc := rpcclient.NewHTTP(nodeRPCAddr, "/websocket")
rpc, err := rpcclient.NewHTTP(nodeRPCAddr, "/websocket")
if err != nil {
return errors.Wrap(err, "failed to create new http client")
}
home := viper.GetString(cli.HomeFlag)
conf := cfg.DefaultConfig()

5
cmd/tendermint/commands/lite.go
View File

@@ -80,7 +80,10 @@ func runProxy(cmd *cobra.Command, args []string) error {
// First, connect a client
logger.Info("Connecting to source HTTP client...")
node := rpcclient.NewHTTP(nodeAddr, "/websocket")
node, err := rpcclient.NewHTTP(nodeAddr, "/websocket")
if err != nil {
return errors.Wrap(err, "new HTTP client")
}
logger.Info("Constructing Verifier...")
cert, err := proxy.NewVerifier(chainID, home, node, logger, cacheSize)