more linting

p2p/fuzz.go

@@ -124,7 +124,7 @@ func (fc *FuzzedConnection) SetWriteDeadline(t time.Time) error {
 
 func (fc *FuzzedConnection) randomDuration() time.Duration {
 	maxDelayMillis := int(fc.config.MaxDelay.Nanoseconds() / 1000)
-	return time.Millisecond * time.Duration(rand.Int()%maxDelayMillis)
+	return time.Millisecond * time.Duration(rand.Int()%maxDelayMillis) // nolint: gas
 }
 
 // implements the fuzz (delay, kill conn)
@@ -143,7 +143,7 @@ func (fc *FuzzedConnection) fuzz() bool {
 		} else if r < fc.config.ProbDropRW+fc.config.ProbDropConn {
 			// XXX: can't this fail because machine precision?
 			// XXX: do we need an error?
-			fc.Close() // nolint: errcheck
+			fc.Close() // nolint: errcheck, gas
 			return true
 		} else if r < fc.config.ProbDropRW+fc.config.ProbDropConn+fc.config.ProbSleep {
 			time.Sleep(fc.randomDuration())

p2p/pex_reactor.go

@@ -283,7 +283,7 @@ func (r *PEXReactor) ensurePeers() {
 	// If we need more addresses, pick a random peer and ask for more.
 	if r.book.NeedMoreAddrs() {
 		if peers := r.Switch.Peers().List(); len(peers) > 0 {
-			i := rand.Int() % len(peers)
+			i := rand.Int() % len(peers) // nolint: gas
 			peer := peers[i]
 			r.Logger.Info("No addresses to dial. Sending pexRequest to random peer", "peer", peer)
 			r.RequestPEX(peer)

p2p/secret_connection.go

@@ -302,7 +302,7 @@ func shareAuthSignature(sc *SecretConnection, pubKey crypto.PubKeyEd25519, signa
 // sha256
 func hash32(input []byte) (res *[32]byte) {
 	hasher := sha256.New()
-	hasher.Write(input) // nolint: errcheck
+	hasher.Write(input) // nolint: errcheck, gas
 	resSlice := hasher.Sum(nil)
 	res = new([32]byte)
 	copy(res[:], resSlice)
@@ -312,7 +312,7 @@ func hash32(input []byte) (res *[32]byte) {
 // We only fill in the first 20 bytes with ripemd160
 func hash24(input []byte) (res *[24]byte) {
 	hasher := ripemd160.New()
-	hasher.Write(input) // nolint: errcheck
+	hasher.Write(input) // nolint: errcheck, gas
 	resSlice := hasher.Sum(nil)
 	res = new([24]byte)
 	copy(res[:], resSlice)

p2p/trust/trustmetric.go

@@ -47,7 +47,9 @@ func NewTrustMetricStore(db dbm.DB, tmc TrustMetricConfig) *TrustMetricStore {
 
 // OnStart implements Service
 func (tms *TrustMetricStore) OnStart() error {
-	tms.BaseService.OnStart()
+	if err := tms.BaseService.OnStart(); err != nil {
+		return err
+	}
 
 	tms.mtx.Lock()
 	defer tms.mtx.Unlock()

p2p/types.go

@@ -55,12 +55,12 @@ func (info *NodeInfo) CompatibleWith(other *NodeInfo) error {
 }
 
 func (info *NodeInfo) ListenHost() string {
-	host, _, _ := net.SplitHostPort(info.ListenAddr)
+	host, _, _ := net.SplitHostPort(info.ListenAddr) // nolint: errcheck, gas
 	return host
 }
 
 func (info *NodeInfo) ListenPort() int {
-	_, port, _ := net.SplitHostPort(info.ListenAddr)
+	_, port, _ := net.SplitHostPort(info.ListenAddr) // nolint: errcheck, gas
 	port_i, err := strconv.Atoi(port)
 	if err != nil {
 		return -1

p2p/util.go

@@ -7,9 +7,9 @@ import (
 // doubleSha256 calculates sha256(sha256(b)) and returns the resulting bytes.
 func doubleSha256(b []byte) []byte {
 	hasher := sha256.New()
-	hasher.Write(b) // nolint: errcheck
+	hasher.Write(b) // nolint: errcheck, gas
 	sum := hasher.Sum(nil)
 	hasher.Reset()
-	hasher.Write(sum) // nolint: errcheck
+	hasher.Write(sum) // nolint: errcheck, gas
 	return hasher.Sum(nil)
 }