From a4b4fdaff6ab14c84a0c522adb991730c2c84ecc Mon Sep 17 00:00:00 2001 From: tycho garen Date: Thu, 17 Jun 2021 09:18:52 -0400 Subject: [PATCH] be more clear about future work --- docs/architecture/adr-069-flexible-node-intitalization.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/architecture/adr-069-flexible-node-intitalization.md b/docs/architecture/adr-069-flexible-node-intitalization.md index 18d26828f..3f5272feb 100644 --- a/docs/architecture/adr-069-flexible-node-intitalization.md +++ b/docs/architecture/adr-069-flexible-node-intitalization.md @@ -132,6 +132,14 @@ point, a cluster of dependencies can be wrapped as a single `service.BaseService` and `service.Service` implementations is troubling, the default panic in `OnReset` seems troubling.) +- As part of the refactor of `service.Service` have all services/nodes + respect the lifetime of a `context.Context` object, and avoid the + current practice of creating `context.Context` objects in p2p and + reactor code. This would be required for in-process multi-tenancy. + +- Consider additional interfaces that node objects can provide in + terms of access to components (e.g. the mempool). + - Support explicit dependencies between components and allow for parallel startup, so that different reactors can startup at the same time, where possible.