From adfdfca2274373b1229e4ac161814d5bf23dceb3 Mon Sep 17 00:00:00 2001 From: Thane Thomson Date: Thu, 28 Apr 2022 18:17:16 -0400 Subject: [PATCH] Add note to remove TxResult proto As Sergio pointed out in 3e31aa6f583cdc71e208ed03a82f1d804ec0de49, this proto message can probably be removed. We should do this in a separate PR. Signed-off-by: Thane Thomson --- proto/tendermint/abci/types.proto | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/proto/tendermint/abci/types.proto b/proto/tendermint/abci/types.proto index d8143feb3..31a9c72fe 100644 --- a/proto/tendermint/abci/types.proto +++ b/proto/tendermint/abci/types.proto @@ -424,6 +424,10 @@ message ExecTxResult { // TxResult contains results of executing the transaction. // // One usage is indexing transaction results. +// TODO(thane): Remove this struct. It's effectively only used in +// types/events.go#EventDataTx and these fields could easily be +// introduced directly into that struct. There doesn't seem to be +// any other use for this struct via any other interface. message TxResult { int64 height = 1; uint32 index = 2;