mempool: migrate rechecktx to be a consensus parameter (#8514)

scripts/confix/plan.go

@@ -222,4 +222,10 @@ var plan = transform.Plan{
 			return fmt.Errorf("unrecognized value: %v", idx.KeyValue)
 		}),
 	},
+	{
+		// Since https://github.com/tendermint/tendermint/pull/8514.
+		Desc:    "Remove the recheck option from the [mempool] section",
+		T:       transform.Remove(parser.Key{"mempool", "recheck"}),
+		ErrorOK: true,
+	},
 }

scripts/confix/testdata/diff-35-36.txt

@@ -9,6 +9,7 @@
 -M consensus.timeout-prevote-delta
 -M consensus.timeout-propose
 -M consensus.timeout-propose-delta
+-M mempool.recheck
 -M mempool.version
 -M p2p.addr-book-file
 -M p2p.addr-book-strict

scripts/confix/testdata/v36-config.toml

@@ -281,7 +281,11 @@ recv-rate = 5120000
 #######################################################
 [mempool]
 
-recheck = true
+# recheck has been moved from a config option to a global
+# consensus param in v0.36
+# See https://github.com/tendermint/tendermint/issues/8244 for more information.
+
+# Set true to broadcast transactions in the mempool to other nodes
 broadcast = true
 
 # Maximum number of transactions in the mempool