types: Remove NewExtendedCommit constructor

Signed-off-by: Thane Thomson <connect@thanethomson.com>

types/block.go

@@ -1083,16 +1083,6 @@ type ExtendedCommit struct {
 	bitArray *bits.BitArray
 }
 
-// NewExtendedCommit constructs an ExtendedCommit from the given parameters.
-func NewExtendedCommit(height int64, round int32, blockID BlockID, extCommitSigs []ExtendedCommitSig) *ExtendedCommit {
-	return &ExtendedCommit{
-		Height:             height,
-		Round:              round,
-		BlockID:            blockID,
-		ExtendedSignatures: extCommitSigs,
-	}
-}
-
 // Copy creates a copy of this extended commit.
 func (extCommit *ExtendedCommit) Copy() *ExtendedCommit {
 	ec := *extCommit

types/vote_set.go

@@ -635,7 +635,12 @@ func (voteSet *VoteSet) MakeExtendedCommit() *ExtendedCommit {
 		extCommitSigs[i] = extCommitSig
 	}
 
-	return NewExtendedCommit(voteSet.GetHeight(), voteSet.GetRound(), *voteSet.maj23, extCommitSigs)
+	return &ExtendedCommit{
+		Height:             voteSet.GetHeight(),
+		Round:              voteSet.GetRound(),
+		BlockID:            *voteSet.maj23,
+		ExtendedSignatures: extCommitSigs,
+	}
 }
 
 //--------------------------------------------------------------------------------