lint: add errchecks (#5316)

## Description

Work towards enabling errcheck

ref #5059
This commit is contained in:
Marko
2020-09-04 13:58:03 +02:00
committed by GitHub
parent 59ec3d91e4
commit b8d08b9ef4
43 changed files with 420 additions and 143 deletions

View File

@@ -126,7 +126,9 @@ func (wal *BaseWAL) OnStart() error {
if err != nil {
return err
} else if size == 0 {
wal.WriteSync(EndHeightMessage{0})
if err := wal.WriteSync(EndHeightMessage{0}); err != nil {
return err
}
}
err = wal.group.Start()
if err != nil {
@@ -161,8 +163,12 @@ func (wal *BaseWAL) FlushAndSync() error {
// before cleaning up files.
func (wal *BaseWAL) OnStop() {
wal.flushTicker.Stop()
wal.FlushAndSync()
wal.group.Stop()
if err := wal.FlushAndSync(); err != nil {
wal.Logger.Error("error on flush data to disk", "error", err)
}
if err := wal.group.Stop(); err != nil {
wal.Logger.Error("error trying to stop wal", "error", err)
}
wal.group.Close()
}