From bf1a8e180ab4e4927d3cb7f02c6e36a5c685e021 Mon Sep 17 00:00:00 2001 From: William Banfield Date: Fri, 2 Sep 2022 12:01:17 -0400 Subject: [PATCH] comment regarding parallel ordering --- test/loadtime/report/report.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/loadtime/report/report.go b/test/loadtime/report/report.go index 24a805c37..3fd028987 100644 --- a/test/loadtime/report/report.go +++ b/test/loadtime/report/report.go @@ -38,6 +38,8 @@ type Report struct { NegativeCount int // All contains all data points gathered from all valid transactions. + // The order of the contents of All is not guaranteed to be match the order of transactions + // in the chain. All []time.Duration } @@ -53,6 +55,11 @@ func GenerateFromBlockStore(s BlockStore) (Report, error) { bt time.Time } + // Deserializing to proto can be slow but does not depend on other data + // and can therefore be done in parallel. + // Deserializing in parallel does mean that the resulting data is + // not guaranteed to be delivered in the same order it was given to the + // worker pool. const poolSize = 16 txc := make(chan txData)