mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-04 04:04:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

p2p: remove NewNetAddressStringWithOptionalID (#3711)

Browse Source 
Fixes #3521

The function NewNetAddressStringWithOptionalID is from a time when peer
IDs were optional. They're not anymore. So this should be renamed to
NewNetAddressString and should ensure the ID is provided.

* update changelog
* use NewNetAddress in transport tests
* use NewNetAddress in TestTransportMultiplexAcceptMultiple
This commit is contained in:
Anton Kaliaev
2019-06-06 00:39:28 +09:00
committed by Alexander Simmerl
parent a7e8fbf3a7
commit c1f264822a
6 changed files with 62 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
node/node.go
View File

@@ -674,7 +674,7 @@ func (n *Node) OnStart() error {
}
// Start the transport.
addr, err := p2p.NewNetAddressStringWithOptionalID(n.config.P2P.ListenAddress)
addr, err := p2p.NewNetAddressString(p2p.IDAddressString(n.nodeKey.ID(), n.config.P2P.ListenAddress))
if err != nil {
return err
}