From c420dd450773594918435e0882cc481583a56980 Mon Sep 17 00:00:00 2001 From: Thane Thomson Date: Wed, 13 Apr 2022 13:09:16 -0400 Subject: [PATCH] Add TODO to always require extension signatures in vote validation Signed-off-by: Thane Thomson --- types/vote.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/types/vote.go b/types/vote.go index 6d903fc08..e66f40396 100644 --- a/types/vote.go +++ b/types/vote.go @@ -224,6 +224,8 @@ func (vote *Vote) ValidateBasic() error { return fmt.Errorf("signature is too big (max: %d)", MaxSignatureSize) } + // TODO: Remove the extension length check such that we always require + // extension signatures to be present. if len(vote.Extension) > 0 && len(vote.ExtensionSignature) == 0 { return errors.New("vote extension signature is missing") }