diff --git a/blockchain/v0/reactor_test.go b/blockchain/v0/reactor_test.go index a31c9a141..bddbb3f3b 100644 --- a/blockchain/v0/reactor_test.go +++ b/blockchain/v0/reactor_test.go @@ -13,6 +13,7 @@ import ( abci "github.com/tendermint/tendermint/abci/types" cfg "github.com/tendermint/tendermint/config" + evmock "github.com/tendermint/tendermint/evidence/mock" "github.com/tendermint/tendermint/libs/log" "github.com/tendermint/tendermint/mock" "github.com/tendermint/tendermint/p2p" @@ -82,7 +83,7 @@ func newBlockchainReactor( fastSync := true db := dbm.NewMemDB() blockExec := sm.NewBlockExecutor(db, log.TestingLogger(), proxyApp.Consensus(), - mock.Mempool{}, sm.MockEvidencePool{}) + mock.Mempool{}, evmock.NewDefaultEvidencePool()) sm.SaveState(db, state) // let's add some blocks in diff --git a/blockchain/v1/reactor_test.go b/blockchain/v1/reactor_test.go index e0b3472bf..762e72db9 100644 --- a/blockchain/v1/reactor_test.go +++ b/blockchain/v1/reactor_test.go @@ -16,6 +16,7 @@ import ( abci "github.com/tendermint/tendermint/abci/types" cfg "github.com/tendermint/tendermint/config" + evmock "github.com/tendermint/tendermint/evidence/mock" "github.com/tendermint/tendermint/libs/log" "github.com/tendermint/tendermint/mock" "github.com/tendermint/tendermint/p2p" @@ -112,7 +113,7 @@ func newBlockchainReactor( fastSync := true db := dbm.NewMemDB() blockExec := sm.NewBlockExecutor(db, log.TestingLogger(), proxyApp.Consensus(), - mock.Mempool{}, sm.MockEvidencePool{}) + mock.Mempool{}, evmock.NewDefaultEvidencePool()) sm.SaveState(db, state) // let's add some blocks in diff --git a/blockchain/v2/reactor_test.go b/blockchain/v2/reactor_test.go index 10b1d23df..4b3013a2d 100644 --- a/blockchain/v2/reactor_test.go +++ b/blockchain/v2/reactor_test.go @@ -15,6 +15,7 @@ import ( abci "github.com/tendermint/tendermint/abci/types" "github.com/tendermint/tendermint/behaviour" cfg "github.com/tendermint/tendermint/config" + evmock "github.com/tendermint/tendermint/evidence/mock" "github.com/tendermint/tendermint/libs/log" "github.com/tendermint/tendermint/libs/service" "github.com/tendermint/tendermint/mock" @@ -152,7 +153,7 @@ func newTestReactor(p testReactorParams) *BlockchainReactor { panic(errors.Wrap(err, "error start app")) } db := dbm.NewMemDB() - appl = sm.NewBlockExecutor(db, p.logger, proxyApp.Consensus(), mock.Mempool{}, sm.MockEvidencePool{}) + appl = sm.NewBlockExecutor(db, p.logger, proxyApp.Consensus(), mock.Mempool{}, evmock.NewDefaultEvidencePool()) sm.SaveState(db, state) } @@ -494,7 +495,7 @@ func newReactorStore( db := dbm.NewMemDB() blockExec := sm.NewBlockExecutor(db, log.TestingLogger(), proxyApp.Consensus(), - mock.Mempool{}, sm.MockEvidencePool{}) + mock.Mempool{}, evmock.NewDefaultEvidencePool()) sm.SaveState(db, state) // add blocks in diff --git a/consensus/common_test.go b/consensus/common_test.go index f8055f01c..e98c66837 100644 --- a/consensus/common_test.go +++ b/consensus/common_test.go @@ -26,6 +26,7 @@ import ( abci "github.com/tendermint/tendermint/abci/types" cfg "github.com/tendermint/tendermint/config" cstypes "github.com/tendermint/tendermint/consensus/types" + evmock "github.com/tendermint/tendermint/evidence/mock" tmbytes "github.com/tendermint/tendermint/libs/bytes" "github.com/tendermint/tendermint/libs/log" tmos "github.com/tendermint/tendermint/libs/os" @@ -373,7 +374,7 @@ func newStateWithConfigAndBlockStore( } // mock the evidence pool - evpool := sm.MockEvidencePool{} + evpool := evmock.NewDefaultEvidencePool() // Make State stateDB := blockDB diff --git a/consensus/replay.go b/consensus/replay.go index 3d9d6614b..0245a5341 100644 --- a/consensus/replay.go +++ b/consensus/replay.go @@ -15,6 +15,7 @@ import ( //auto "github.com/tendermint/tendermint/libs/autofile" dbm "github.com/tendermint/tm-db" + evmock "github.com/tendermint/tendermint/evidence/mock" "github.com/tendermint/tendermint/libs/log" "github.com/tendermint/tendermint/mock" "github.com/tendermint/tendermint/proxy" @@ -473,7 +474,7 @@ func (h *Handshaker) replayBlock(state sm.State, height int64, proxyApp proxy.Ap block := h.store.LoadBlock(height) meta := h.store.LoadBlockMeta(height) - blockExec := sm.NewBlockExecutor(h.stateDB, h.logger, proxyApp, mock.Mempool{}, sm.MockEvidencePool{}) + blockExec := sm.NewBlockExecutor(h.stateDB, h.logger, proxyApp, mock.Mempool{}, evmock.NewDefaultEvidencePool()) blockExec.SetEventBus(h.eventBus) var err error diff --git a/consensus/replay_file.go b/consensus/replay_file.go index b8b8c51da..e27584ba0 100644 --- a/consensus/replay_file.go +++ b/consensus/replay_file.go @@ -13,6 +13,7 @@ import ( dbm "github.com/tendermint/tm-db" cfg "github.com/tendermint/tendermint/config" + evmock "github.com/tendermint/tendermint/evidence/mock" "github.com/tendermint/tendermint/libs/log" tmos "github.com/tendermint/tendermint/libs/os" "github.com/tendermint/tendermint/mock" @@ -311,7 +312,7 @@ func newConsensusStateForReplay(config cfg.BaseConfig, csConfig *cfg.ConsensusCo tmos.Exit(fmt.Sprintf("Error on handshake: %v", err)) } - mempool, evpool := mock.Mempool{}, sm.MockEvidencePool{} + mempool, evpool := mock.Mempool{}, evmock.NewDefaultEvidencePool() blockExec := sm.NewBlockExecutor(stateDB, log.TestingLogger(), proxyApp.Consensus(), mempool, evpool) consensusState := NewState(csConfig, state.Copy(), blockExec, diff --git a/consensus/replay_test.go b/consensus/replay_test.go index f886cdeeb..7fd4f9e6d 100644 --- a/consensus/replay_test.go +++ b/consensus/replay_test.go @@ -23,6 +23,7 @@ import ( abci "github.com/tendermint/tendermint/abci/types" cfg "github.com/tendermint/tendermint/config" "github.com/tendermint/tendermint/crypto" + evmock "github.com/tendermint/tendermint/evidence/mock" "github.com/tendermint/tendermint/libs/log" tmrand "github.com/tendermint/tendermint/libs/rand" mempl "github.com/tendermint/tendermint/mempool" @@ -296,7 +297,7 @@ const ( var ( mempool = mock.Mempool{} - evpool = sm.MockEvidencePool{} + evpool = evmock.NewDefaultEvidencePool() sim testSim ) diff --git a/consensus/wal_generator.go b/consensus/wal_generator.go index 422c3f73b..f14d11db3 100644 --- a/consensus/wal_generator.go +++ b/consensus/wal_generator.go @@ -15,6 +15,7 @@ import ( "github.com/tendermint/tendermint/abci/example/kvstore" cfg "github.com/tendermint/tendermint/config" + evmock "github.com/tendermint/tendermint/evidence/mock" "github.com/tendermint/tendermint/libs/log" tmrand "github.com/tendermint/tendermint/libs/rand" "github.com/tendermint/tendermint/mock" @@ -73,7 +74,7 @@ func WALGenerateNBlocks(t *testing.T, wr io.Writer, numBlocks int) (err error) { } defer eventBus.Stop() mempool := mock.Mempool{} - evpool := sm.MockEvidencePool{} + evpool := evmock.NewDefaultEvidencePool() blockExec := sm.NewBlockExecutor(stateDB, log.TestingLogger(), proxyApp.Consensus(), mempool, evpool) consensusState := NewState(config.Consensus, state.Copy(), blockExec, blockStore, mempool, evpool) consensusState.SetLogger(logger) diff --git a/types/evidence.go b/types/evidence.go index fef9977c0..9dd7c9823 100644 --- a/types/evidence.go +++ b/types/evidence.go @@ -975,13 +975,7 @@ func (e MockEvidence) Bytes() []byte { return []byte(fmt.Sprintf("%d-%x-%s", e.EvidenceHeight, e.EvidenceAddress, e.EvidenceTime)) } -func (e MockEvidence) Verify(chainID string, pubKey crypto.PubKey) error { - if !bytes.Equal(pubKey.Address(), e.Address()) { - return fmt.Errorf("address (%X) doesn't match pubkey (%v - %X)", - e.Address(), pubKey, pubKey.Address()) - } - return nil -} +func (e MockEvidence) Verify(chainID string, pubKey crypto.PubKey) error { return nil } func (e MockEvidence) Equal(ev Evidence) bool { e2 := ev.(MockEvidence) return e.EvidenceHeight == e2.EvidenceHeight &&