From d25198288a0a938a6d654f0ffcb0df39a9135356 Mon Sep 17 00:00:00 2001 From: William Banfield <4561443+williambanfield@users.noreply.github.com> Date: Mon, 21 Mar 2022 12:57:34 -0400 Subject: [PATCH] ABCI++: Update new protos to use enum instead of bool (#8158) closes: #8039 This pull request updates the new ABCI++ protos to use `enum`s in place of `bool`s. `enums` may be preferred over `bool` because an `enum` can be udpated to include new statuses in the future, whereas a `bool` cannot and is fixed as just `true` or `false` over the whole lifecycle of the API. --- state/execution.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/state/execution.go b/state/execution.go index 0d8153e12..03628d877 100644 --- a/state/execution.go +++ b/state/execution.go @@ -132,7 +132,7 @@ func (blockExec *BlockExecutor) CreateProposalBlock( // Either way, we cannot recover in a meaningful way, unless we skip proposing // this block, repair what caused the error and try again. Hence, we return an // error for now (the production code calling this function is expected to panic). - return nil, err + panic(err) } txrSet := types.NewTxRecordSet(rpp.TxRecords)