libs/service: pass logger explicitly (#7288)

This is a very small change, but removes a method from the
`service.Service` interface (a win!) and forces callers to explicitly
pass loggers in to objects during construction rather than (later)
injecting them. There's not a real need for this kind of lazy
construction of loggers, and I think a decent potential for confusion
for mutable loggers.

The main concern I have is that this changes the constructor API for
ABCI clients. I think this is fine, and I suspect that as we plumb
contexts through, and make changes to the RPC services there'll be a
number of similar sorts of changes to various (quasi) public
interfaces, which I think we should welcome.

node/setup.go

@@ -90,17 +90,17 @@ func initDBs(
 
 // nolint:lll
 func createAndStartProxyAppConns(clientCreator abciclient.Creator, logger log.Logger, metrics *proxy.Metrics) (proxy.AppConns, error) {
-	proxyApp := proxy.NewAppConns(clientCreator, metrics)
-	proxyApp.SetLogger(logger.With("module", "proxy"))
+	proxyApp := proxy.NewAppConns(clientCreator, logger.With("module", "proxy"), metrics)
+
 	if err := proxyApp.Start(); err != nil {
 		return nil, fmt.Errorf("error starting proxy app connections: %v", err)
 	}
+
 	return proxyApp, nil
 }
 
 func createAndStartEventBus(logger log.Logger) (*eventbus.EventBus, error) {
-	eventBus := eventbus.NewDefault()
-	eventBus.SetLogger(logger.With("module", "events"))
+	eventBus := eventbus.NewDefault(logger.With("module", "events"))
 	if err := eventBus.Start(); err != nil {
 		return nil, err
 	}
@@ -309,6 +309,7 @@ func createConsensusReactor(
 	logger = logger.With("module", "consensus")
 
 	consensusState := consensus.NewState(
+		logger,
 		cfg.Consensus,
 		state.Copy(),
 		blockExec,
@@ -317,7 +318,7 @@ func createConsensusReactor(
 		evidencePool,
 		consensus.StateMetrics(csMetrics),
 	)
-	consensusState.SetLogger(logger)
+
 	if privValidator != nil && cfg.Mode == config.ModeValidator {
 		consensusState.SetPrivValidator(privValidator)
 	}