libs/service: pass logger explicitly (#7288)

This is a very small change, but removes a method from the
`service.Service` interface (a win!) and forces callers to explicitly
pass loggers in to objects during construction rather than (later)
injecting them. There's not a real need for this kind of lazy
construction of loggers, and I think a decent potential for confusion
for mutable loggers.

The main concern I have is that this changes the constructor API for
ABCI clients. I think this is fine, and I suspect that as we plumb
contexts through, and make changes to the RPC services there'll be a
number of similar sorts of changes to various (quasi) public
interfaces, which I think we should welcome.

test/e2e/node/main.go

@@ -102,7 +102,7 @@ func startApp(cfg *Config) error {
 	if err != nil {
 		return err
 	}
-	server, err := server.NewServer(cfg.Listen, cfg.Protocol, app)
+	server, err := server.NewServer(logger, cfg.Listen, cfg.Protocol, app)
 	if err != nil {
 		return err
 	}

test/fuzz/mempool/checktx.go

@@ -16,7 +16,7 @@ var getMp func() mempool.Mempool
 func init() {
 	app := kvstore.NewApplication()
 	cc := abciclient.NewLocalCreator(app)
-	appConnMem, _ := cc()
+	appConnMem, _ := cc(log.NewNopLogger())
 	err := appConnMem.Start()
 	if err != nil {
 		panic(err)