From e0badc0b2f17ca090100d55abf0525156a82ef9f Mon Sep 17 00:00:00 2001 From: William Banfield Date: Wed, 11 May 2022 09:57:26 -0400 Subject: [PATCH] rename diff function --- scripts/metricsgen/metricsdiff/metricsdiff.go | 6 +++--- scripts/metricsgen/metricsdiff/metricsdiff_test.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/metricsgen/metricsdiff/metricsdiff.go b/scripts/metricsgen/metricsdiff/metricsdiff.go index 0e653a17f..7d3cbea93 100644 --- a/scripts/metricsgen/metricsdiff/metricsdiff.go +++ b/scripts/metricsgen/metricsdiff/metricsdiff.go @@ -59,16 +59,16 @@ func main() { if err != nil { log.Fatalf("Unable to open file %s: %v", os.Args[2], err) } - md, err := MetricsDiffFromReaders(fa, fb) + md, err := DiffFromReaders(fa, fb) if err != nil { log.Fatalf("Generating diff: %v", err) } fmt.Printf("%s", md) } -// MetricsDiffFromReaders parses the metrics present in the readers a and b and +// DiffFromReaders parses the metrics present in the readers a and b and // determines which metrics were added and removed in b. -func MetricsDiffFromReaders(a, b io.Reader) (Diff, error) { +func DiffFromReaders(a, b io.Reader) (Diff, error) { parser := expfmt.TextParser{} amf, err := parser.TextToMetricFamilies(a) if err != nil { diff --git a/scripts/metricsgen/metricsdiff/metricsdiff_test.go b/scripts/metricsgen/metricsdiff/metricsdiff_test.go index 393ee4609..efae5bddd 100644 --- a/scripts/metricsgen/metricsdiff/metricsdiff_test.go +++ b/scripts/metricsgen/metricsdiff/metricsdiff_test.go @@ -56,7 +56,7 @@ func TestDiff(t *testing.T) { require.NoError(t, err) _, err = io.WriteString(bufB, tc.bContents) require.NoError(t, err) - md, err := metricsdiff.MetricsDiffFromReaders(bufA, bufB) + md, err := metricsdiff.DiffFromReaders(bufA, bufB) require.NoError(t, err) require.Equal(t, tc.want, md) })