mirror of
https://github.com/tendermint/tendermint.git
synced 2026-01-07 05:46:32 +00:00
state: require block.Time of the fist block to be genesis time (#2594)
* require block.Time of the fist block to be genesis time Refs #2587: ``` We only start validating block.Time when Height > 1, because there is no commit to compute the median timestamp from for the first block. This means a faulty proposer could make the first block with whatever time they want. Instead, we should require the timestamp of block 1 to match the genesis time. I discovered this while refactoring the ValidateBlock tests to be table-driven while working on tests for #2560. ``` * do not accept blocks with negative height * update changelog and spec * nanos precision for test genesis time * Fix failing test (#2607)
This commit is contained in:
committed by
Ethan Buchman
parent
3744e8271d
commit
e1538bf67e
@@ -118,10 +118,7 @@ func (state State) MakeBlock(
|
||||
|
||||
// Set time
|
||||
if height == 1 {
|
||||
block.Time = tmtime.Now()
|
||||
if block.Time.Before(state.LastBlockTime) {
|
||||
block.Time = state.LastBlockTime // state.LastBlockTime for height == 1 is genesis time
|
||||
}
|
||||
block.Time = state.LastBlockTime // genesis time
|
||||
} else {
|
||||
block.Time = MedianTime(commit, state.LastValidators)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user