From e4dd69118adc14e213ea2bdd00c92cf538359c80 Mon Sep 17 00:00:00 2001 From: Thane Thomson Date: Thu, 14 Apr 2022 17:40:53 -0400 Subject: [PATCH] e2e: add error logs when we get an unexpected height in ExtendVote or VerifyVoteExtension requests Signed-off-by: Thane Thomson --- test/e2e/app/app.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/test/e2e/app/app.go b/test/e2e/app/app.go index e78564904..797c3b99c 100644 --- a/test/e2e/app/app.go +++ b/test/e2e/app/app.go @@ -429,6 +429,11 @@ func (app *Application) ExtendVote(req abci.RequestExtendVote) abci.ResponseExte // We ignore any requests for vote extensions that don't match our expected // next height. if req.Height != int64(app.state.Height)+1 { + app.logger.Error( + "got unexpected height in ExtendVote request", + "expectedHeight", app.state.Height+1, + "requestHeight", req.Height, + ) return abci.ResponseExtendVote{} } ext := make([]byte, binary.MaxVarintLen64) @@ -455,9 +460,9 @@ func (app *Application) VerifyVoteExtension(req abci.RequestVerifyVoteExtension) } if req.Height != int64(app.state.Height)+1 { app.logger.Error( - "got request to verify a vote extension at an unexpected height", + "got unexpected height in VerifyVoteExtension request", + "expectedHeight", app.state.Height, "requestHeight", req.Height, - "appHeight", app.state.Height, ) return abci.ResponseVerifyVoteExtension{ Status: abci.ResponseVerifyVoteExtension_REJECT,