mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-07 13:55:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint fixes

Browse Source
This commit is contained in:
William Banfield
2022-10-26 18:19:18 -04:00
parent 074f5f1bf4
commit e561129f43
7 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
blocksync/reactor.go
View File

@@ -283,7 +283,7 @@ func (bcR *Reactor) poolRoutine(stateSynced bool) {
case <-statusUpdateTicker.C: case <-statusUpdateTicker.C:
// ask for status updates // ask for status updates
go bcR.BroadcastStatusRequest() //nolint: errcheck go bcR.BroadcastStatusRequest()
} }
} }

3
cmd/tendermint/commands/debug/util.go
View File

@@ -67,7 +67,8 @@ func copyConfig(home, dir string) error {
func dumpProfile(dir, addr, profile string, debug int) error { func dumpProfile(dir, addr, profile string, debug int) error {
endpoint := fmt.Sprintf("%s/debug/pprof/%s?debug=%d", addr, profile, debug) endpoint := fmt.Sprintf("%s/debug/pprof/%s?debug=%d", addr, profile, debug)
resp, err := http.Get(endpoint) //nolint: gosec //nolint: gosec
resp, err := http.Get(endpoint)
if err != nil { if err != nil {
return fmt.Errorf("failed to query for %s profile: %w", profile, err) return fmt.Errorf("failed to query for %s profile: %w", profile, err)
} }

2
cmd/tendermint/commands/rollback.go
View File

@@ -14,7 +14,7 @@ import (
"github.com/tendermint/tendermint/store" "github.com/tendermint/tendermint/store"
) )
var removeBlock bool = false var removeBlock = false
func init() { func init() {
RollbackStateCmd.Flags().BoolVar(&removeBlock, "hard", false, "remove last block as well as state") RollbackStateCmd.Flags().BoolVar(&removeBlock, "hard", false, "remove last block as well as state")

3
consensus/msgs.go
View File

@@ -307,6 +307,9 @@ func WALFromProto(msg *tmcons.WALMessage) (WALMessage, error) {
} }
case *tmcons.WALMessage_MsgInfo: case *tmcons.WALMessage_MsgInfo:
um, err := msg.MsgInfo.Msg.Unwrap() um, err := msg.MsgInfo.Msg.Unwrap()
if err != nil {
return nil, fmt.Errorf("unwrap message: %w", err)
}
walMsg, err := MsgFromProto(um) walMsg, err := MsgFromProto(um)
if err != nil { if err != nil {
return nil, fmt.Errorf("msgInfo from proto error: %w", err) return nil, fmt.Errorf("msgInfo from proto error: %w", err)

2
libs/rand/random.go
View File

@@ -48,7 +48,7 @@ func (r *Rand) init() {
} }
func (r *Rand) reset(seed int64) { func (r *Rand) reset(seed int64) {
r.rand = mrand.New(mrand.NewSource(seed)) //nolint:gosec r.rand = mrand.New(mrand.NewSource(seed))
} }
//---------------------------------------- //----------------------------------------

3
mempool/v0/reactor_test.go
View File

@@ -22,7 +22,6 @@ import (
"github.com/tendermint/tendermint/p2p" "github.com/tendermint/tendermint/p2p"
"github.com/tendermint/tendermint/p2p/mock" "github.com/tendermint/tendermint/p2p/mock"
memproto "github.com/tendermint/tendermint/proto/tendermint/mempool" memproto "github.com/tendermint/tendermint/proto/tendermint/mempool"
protomem "github.com/tendermint/tendermint/proto/tendermint/mempool"
"github.com/tendermint/tendermint/proxy" "github.com/tendermint/tendermint/proxy"
"github.com/tendermint/tendermint/types" "github.com/tendermint/tendermint/types"
) )
@@ -283,7 +282,7 @@ func TestDontExhaustMaxActiveIDs(t *testing.T) {
reactor.Receive(p2p.Envelope{ reactor.Receive(p2p.Envelope{
ChannelID: mempool.MempoolChannel, ChannelID: mempool.MempoolChannel,
Src: peer, Src: peer,
Message: &protomem.Txs{ Message: &memproto.Txs{
Txs: [][]byte{{0x01, 0x02, 0x03}}, Txs: [][]byte{{0x01, 0x02, 0x03}},
}}) }})
reactor.AddPeer(peer) reactor.AddPeer(peer)

11
p2p/switch_test.go
View File

@@ -14,7 +14,7 @@ import (
"testing" "testing"
"time" "time"
"github.com/golang/protobuf/proto" "github.com/cosmos/gogoproto/proto"
"github.com/prometheus/client_golang/prometheus/promhttp" "github.com/prometheus/client_golang/prometheus/promhttp"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
@@ -24,7 +24,6 @@ import (
"github.com/tendermint/tendermint/libs/log" "github.com/tendermint/tendermint/libs/log"
tmsync "github.com/tendermint/tendermint/libs/sync" tmsync "github.com/tendermint/tendermint/libs/sync"
"github.com/tendermint/tendermint/p2p/conn" "github.com/tendermint/tendermint/p2p/conn"
"github.com/tendermint/tendermint/proto/tendermint/p2p"
p2pproto "github.com/tendermint/tendermint/proto/tendermint/p2p" p2pproto "github.com/tendermint/tendermint/proto/tendermint/p2p"
) )
@@ -138,21 +137,21 @@ func TestSwitches(t *testing.T) {
// Lets send some messages // Lets send some messages
ch0Msg := &p2pproto.PexAddrs{ ch0Msg := &p2pproto.PexAddrs{
Addrs: []p2p.NetAddress{ Addrs: []p2pproto.NetAddress{
{ {
ID: "1", ID: "1",
}, },
}, },
} }
ch1Msg := &p2pproto.PexAddrs{ ch1Msg := &p2pproto.PexAddrs{
Addrs: []p2p.NetAddress{ Addrs: []p2pproto.NetAddress{
{ {
ID: "1", ID: "1",
}, },
}, },
} }
ch2Msg := &p2pproto.PexAddrs{ ch2Msg := &p2pproto.PexAddrs{
Addrs: []p2p.NetAddress{ Addrs: []p2pproto.NetAddress{
{ {
ID: "2", ID: "2",
}, },
@@ -453,7 +452,7 @@ func TestSwitchStopPeerForError(t *testing.T) {
p := sw1.Peers().List()[0] p := sw1.Peers().List()[0]
p.Send(Envelope{ p.Send(Envelope{
ChannelID: 0x1, ChannelID: 0x1,
Message: &p2p.Message{}, Message: &p2pproto.Message{},
}) })
// stop sw2. this should cause the p to fail, // stop sw2. this should cause the p to fail,