node+privval: refactor privval construction (#7574)

This commit is contained in:
Sam Kleinman
2022-01-13 11:53:05 -05:00
committed by GitHub
parent 5a89263dbe
commit ed660bddeb
3 changed files with 129 additions and 112 deletions

View File

@@ -179,8 +179,13 @@ func TestNodeSetPrivValTCP(t *testing.T) {
}()
defer signerServer.Stop() //nolint:errcheck // ignore for tests
n := getTestNode(ctx, t, cfg, logger)
assert.IsType(t, &privval.RetrySignerClient{}, n.PrivValidator())
genDoc, err := defaultGenesisDocProviderFunc(cfg)()
require.NoError(t, err)
pval, err := createPrivval(ctx, logger, cfg, genDoc, nil)
require.NoError(t, err)
assert.IsType(t, &privval.RetrySignerClient{}, pval)
}
// address without a protocol must result in error
@@ -237,8 +242,13 @@ func TestNodeSetPrivValIPC(t *testing.T) {
require.NoError(t, err)
}()
defer pvsc.Stop() //nolint:errcheck // ignore for tests
n := getTestNode(ctx, t, cfg, logger)
assert.IsType(t, &privval.RetrySignerClient{}, n.PrivValidator())
genDoc, err := defaultGenesisDocProviderFunc(cfg)()
require.NoError(t, err)
pval, err := createPrivval(ctx, logger, cfg, genDoc, nil)
require.NoError(t, err)
assert.IsType(t, &privval.RetrySignerClient{}, pval)
}
// testFreeAddr claims a free port so we don't block on listener being ready.