NewXXXClient doesnt run Start or return error

This commit is contained in:
Ethan Buchman
2017-05-15 11:29:34 -04:00
parent fadfcfdcb0
commit eda4f2dddc
9 changed files with 46 additions and 33 deletions

View File

@@ -23,8 +23,8 @@ func TestChainAware(t *testing.T) {
defer srv.Stop()
// Connect to the socket
client, err := abcicli.NewSocketClient("unix://test.sock", false)
if err != nil {
client := abcicli.NewSocketClient("unix://test.sock", false)
if _, err := client.Start(); err != nil {
t.Fatalf("Error starting socket client: %v", err.Error())
}
client.SetLogger(log.TestingLogger().With("module", "abci-client"))

View File

@@ -221,8 +221,8 @@ func makeSocketClientServer(app types.Application, name string) (abcicli.Client,
server.SetLogger(logger.With("module", "abci-server"))
// Connect to the socket
client, err := abcicli.NewSocketClient(socket, false)
if err != nil {
client := abcicli.NewSocketClient(socket, false)
if _, err := client.Start(); err != nil {
server.Stop()
return nil, nil, err
}
@@ -244,8 +244,8 @@ func makeGRPCClientServer(app types.Application, name string) (abcicli.Client, c
}
server.SetLogger(logger.With("module", "abci-server"))
client, err := abcicli.NewGRPCClient(socket, true)
if err != nil {
client := abcicli.NewGRPCClient(socket, true)
if _, err := client.Start(); err != nil {
server.Stop()
return nil, nil, err
}

View File

@@ -46,8 +46,8 @@ func testStream(t *testing.T, app types.Application) {
defer server.Stop()
// Connect to the socket
client, err := abcicli.NewSocketClient("unix://test.sock", false)
if err != nil {
client := abcicli.NewSocketClient("unix://test.sock", false)
if _, err := client.Start(); err != nil {
t.Fatalf("Error starting socket client: %v", err.Error())
}
client.SetLogger(log.TestingLogger().With("module", "abci-client"))