From eed64b30ce5ac0b0659626dc68d59d68452bc045 Mon Sep 17 00:00:00 2001 From: William Banfield Date: Mon, 9 May 2022 18:34:14 -0400 Subject: [PATCH] check file changes in tests --- scripts/metricsgen/metricsgen_test.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/scripts/metricsgen/metricsgen_test.go b/scripts/metricsgen/metricsgen_test.go index 4b3e10cd2..a37bdf0cf 100644 --- a/scripts/metricsgen/metricsgen_test.go +++ b/scripts/metricsgen/metricsgen_test.go @@ -67,6 +67,20 @@ func TestFromData(t *testing.T) { if _, err := parser.ParseFile(token.NewFileSet(), outFile, nil, parser.AllErrors); err != nil { t.Fatalf("unable to parse generated file %s: %v", outFile, err) } + bNew, err := ioutil.ReadFile(outFile) + if err != nil { + t.Fatalf("unable to read generated file %s: %v", outFile, err) + } + goldenFile := path.Join(dirName, "metrics.gen.go") + bOld, err := ioutil.ReadFile(goldenFile) + if err != nil { + t.Fatalf("unable to read file %s: %v", goldenFile, err) + } + if !bytes.Equal(bNew, bOld) { + t.Fatalf("newly generated code in file %s does not match golden file %s\n"+ + "if the output of the metricsgen tool is expected to change run the following make target: \n"+ + "\tmake metrics", outFile, goldenFile) + } }) } }