From ef17093bb4b8fe794a30993a2a9b108d6686f086 Mon Sep 17 00:00:00 2001
From: William Banfield <wbanfield@gmail.com>
Date: Thu, 20 Oct 2022 12:16:02 -0400
Subject: [PATCH] add todo for log line related to unmarshal in mconn receive

---
 p2p/peer.go | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/p2p/peer.go b/p2p/peer.go
index 8ab89dae1..3f9d5e658 100644
--- a/p2p/peer.go
+++ b/p2p/peer.go
@@ -409,15 +409,19 @@ func createMConnection(
 			// which does onPeerError.
 			panic(fmt.Sprintf("Unknown channel %X", chID))
 		}
+		mt := msgTypeByChID[chID]
+		msg := proto.Clone(mt)
+		err := proto.Unmarshal(msgBytes, msg)
+		if err != nil {
+			// TODO(williambanfield) add a log line
+			return
+		}
 		labels := []string{
 			"peer_id", string(p.ID()),
 			"chID", fmt.Sprintf("%#x", chID),
 		}
 		p.metrics.PeerReceiveBytesTotal.With(labels...).Add(float64(len(msgBytes)))
 		p.metrics.MessageReceiveBytesTotal.With("message_type", "tmp").Add(float64(len(msgBytes)))
-		mt := msgTypeByChID[chID]
-		msg := proto.Clone(mt)
-		proto.Unmarshal(msgBytes, msg)
 		reactor.Receive(chID, p, msgBytes)
 		reactor.NewReceive(Envelope{
 			ChannelID: chID,