mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-08 22:23:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: unused parameters (#8372)

Browse Source
This commit is contained in:
Sam Kleinman
2022-04-18 16:45:21 -04:00
committed by GitHub
parent c372390fea
commit efd4f4a40b
17 changed files with 54 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/scmigrate/migrate.go
View File

@@ -115,7 +115,7 @@ func getAllSeenCommits(ctx context.Context, db dbm.DB) ([]toMigrate, error) {
return scData, nil
}
func renameRecord(ctx context.Context, db dbm.DB, keep toMigrate) error {
func renameRecord(db dbm.DB, keep toMigrate) error {
wantKey := makeKeyFromPrefix(prefixSeenCommit)
if bytes.Equal(keep.key, wantKey) {
return nil // we already did this conversion
@@ -143,7 +143,7 @@ func renameRecord(ctx context.Context, db dbm.DB, keep toMigrate) error {
return cerr
}
func deleteRecords(ctx context.Context, db dbm.DB, scData []toMigrate) error {
func deleteRecords(db dbm.DB, scData []toMigrate) error {
// delete all the remaining stale values in a single batch
batch := db.NewBatch()
@@ -179,7 +179,7 @@ func Migrate(ctx context.Context, db dbm.DB) error {
// retain only the latest.
keep, remove := scData[0], scData[1:]
if err := renameRecord(ctx, db, keep); err != nil {
if err := renameRecord(db, keep); err != nil {
return fmt.Errorf("renaming seen commit record: %w", err)
}
@@ -189,7 +189,7 @@ func Migrate(ctx context.Context, db dbm.DB) error {
// Remove any older seen commits. Prior to v0.35, we kept these records for
// all heights, but v0.35 keeps only the latest.
if err := deleteRecords(ctx, db, remove); err != nil {
if err := deleteRecords(db, remove); err != nil {
return fmt.Errorf("writing data: %w", err)
}