mergify[bot]
e914fe40ec
ci: Fix linter complaint (backport #9645 ) ( #9647 )
...
* ci: Fix linter complaint (#9645 )
Fixes a very silly linter complaint that makes absolutely no sense and is blocking the merging of several PRs.
---
#### PR checklist
- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
documentation updates needed
(cherry picked from commit 83b7f4ad5b )
# Conflicts:
# .github/workflows/lint.yml
# .golangci.yml
# cmd/tendermint/commands/debug/util.go
* Resolve conflicts
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* ci: Sync golangci-lint config with main
Minus the spelling configuration that restricts spelling to US English
only.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* make format
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove usage of deprecated io/ioutil package
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove unused mockBlockStore
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* blockchain/v2: Remove unused method
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Bulk fix lints
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* lint: Ignore auto-generated query PEG
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: Thane Thomson <connect@thanethomson.com >
2022-10-29 08:58:18 -04:00
samricotta
dad439f115
Bump linter to 1.47 ( #9218 )
...
*bump linter to 1.47
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
2022-08-11 15:53:17 +02:00
samricotta
fbd754b4de
Backport of sam/abci-responses ( #9090 ) ( #9159 )
...
*backport of sam/abci-responses
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
2022-08-11 10:41:41 +02:00
Joe Abbey
4a1df4911d
fix: "Lazy" Stringers to defer Sprintf and Hash until logs print ( #8845 )
2022-06-23 14:56:34 -04:00
dependabot[bot]
d0031b0503
build(deps): Bump github.com/go-kit/kit from 0.10.0 to 0.12.0 ( #7213 )
...
* build(deps): Bump github.com/go-kit/kit from 0.10.0 to 0.12.0
Bumps [github.com/go-kit/kit](https://github.com/go-kit/kit ) from 0.10.0 to 0.12.0.
- [Release notes](https://github.com/go-kit/kit/releases )
- [Commits](https://github.com/go-kit/kit/compare/v0.10.0...v0.12.0 )
---
updated-dependencies:
- dependency-name: github.com/go-kit/kit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* add nolint
* fix lint
* fix build
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tycho garen <garen@tychoish.com >
2021-11-08 14:39:00 -05:00
mergify[bot]
28ce355656
libs/log: [JSON format] include timestamp (bp #6174 ) ( #6179 )
...
Closes #6146
2021-02-25 11:27:49 +04:00
Anton Kaliaev
72851a12d3
libs/log: format []byte as hexidecimal string (uppercased) ( #5960 )
...
Closes : #5806
Co-authored-by: Lanie Hei <heixx011@umn.edu >
2021-02-11 17:02:38 +01:00
Marko
9379bc92fd
fix lint failures with 1.31 ( #5489 )
2020-10-22 13:36:08 +02:00
Marko
0ed8dba991
lint: enable errcheck ( #5336 )
...
## Description
Enable errcheck linter throughout the codebase
Closes : #5059
2020-09-07 15:03:18 +00:00
Marko
7e2cc1db5e
linter: (1/2) enable errcheck ( #5064 )
...
## Description
partially cleanup in preparation for errcheck
i ignored a bunch of defer errors in tests but with the update to go 1.14 we can use `t.Cleanup(func() { if err := <>; err != nil {..}}` to cover those errors, I will do this in pr number two of enabling errcheck.
ref #5059
2020-07-01 15:13:11 +00:00
Marko
044f1bf288
format: add format cmd & goimport repo ( #4586 )
...
* format: add format cmd & goimport repo
- replaced format command
- added goimports to format command
- ran goimports
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com >
* fix outliers & undo proto file changes
2020-03-23 09:19:26 +01:00
Marko
3e2751d274
lint: Enable Golint ( #4212 )
...
* Fix many golint errors
* Fix golint errors in the 'lite' package
* Don't export Pool.store
* Fix typo
* Revert unwanted changes
* Fix errors in counter package
* Fix linter errors in kvstore package
* Fix linter error in example package
* Fix error in tests package
* Fix linter errors in v2 package
* Fix linter errors in consensus package
* Fix linter errors in evidence package
* Fix linter error in fail package
* Fix linter errors in query package
* Fix linter errors in core package
* Fix linter errors in node package
* Fix linter errors in mempool package
* Fix linter error in conn package
* Fix linter errors in pex package
* Rename PEXReactor export to Reactor
* Fix linter errors in trust package
* Fix linter errors in upnp package
* Fix linter errors in p2p package
* Fix linter errors in proxy package
* Fix linter errors in mock_test package
* Fix linter error in client_test package
* Fix linter errors in coretypes package
* Fix linter errors in coregrpc package
* Fix linter errors in rpcserver package
* Fix linter errors in rpctypes package
* Fix linter errors in rpctest package
* Fix linter error in json2wal script
* Fix linter error in wal2json script
* Fix linter errors in kv package
* Fix linter error in state package
* Fix linter error in grpc_client
* Fix linter errors in types package
* Fix linter error in version package
* Fix remaining errors
* Address review comments
* Fix broken tests
* Reconcile package coregrpc
* Fix golangci bot error
* Fix new golint errors
* Fix broken reference
* Enable golint linter
* minor changes to bring golint into line
* fix failing test
* fix pex reactor naming
* address PR comments
2019-12-05 10:12:08 +01:00
Anton Kaliaev
3e1516b624
linters: enable stylecheck ( #4153 )
...
Refs #3262
2019-11-16 19:35:39 +04:00
Phil Salant
bc572217c0
Fix linter errors thrown by lll ( #3970 )
...
* Fix long line errors in abci, crypto, and libs packages
* Fix long lines in p2p and rpc packages
* Fix long lines in abci, state, and tools packages
* Fix long lines in behaviour and blockchain packages
* Fix long lines in cmd and config packages
* Begin fixing long lines in consensus package
* Finish fixing long lines in consensus package
* Add lll exclusion for lines containing URLs
* Fix long lines in crypto package
* Fix long lines in evidence package
* Fix long lines in mempool and node packages
* Fix long lines in libs package
* Fix long lines in lite package
* Fix new long line in node package
* Fix long lines in p2p package
* Ignore gocritic warning
* Fix long lines in privval package
* Fix long lines in rpc package
* Fix long lines in scripts package
* Fix long lines in state package
* Fix long lines in tools package
* Fix long lines in types package
* Enable lll linter
2019-10-17 10:42:28 +02:00
Phil Salant
d1d517a9b7
linters: enable scopelint ( #3963 )
...
* Pin range scope vars
* Don't disable scopelint
This PR repairs linter errors seen when running the following commands:
golangci-lint run --no-config --disable-all=true --enable=scopelint
Contributes to #3262
2019-09-11 09:15:18 +04:00
Marko
4ba49a4236
deps: bump viper to 1.4.0 and logfmt to 0.4.0 ( #3950 )
...
- depndabot couldnt update a few deps as they needed to beupdated together.
- PRs: #3946 , 3938 can be closed with this PR
Signedoff-by: Marko Baricevic <marbar3778@yahoo.com >
2019-09-05 11:56:32 +04:00
Marko
f9cce282da
gocritic (2/2) ( #3864 )
...
Refs #3262
2019-08-02 10:53:52 +04:00
Anton Kaliaev
5f4d8e031e
[log] fix year format ( #3125 )
...
Refs #3060
2019-01-14 14:10:13 -05:00
Dev Ojha
df32ea4be5
Make testing logger that doesn't write to stdout ( #2997 )
2018-12-11 12:17:21 +04:00
Anton Kaliaev
98e442a8de
return back initially allowed level if we encounter allowed key ( #2889 )
...
Fixes #2868 where module=main setting overrides all others
2018-11-25 23:34:22 -05:00
yutianwu
60437953ac
[R4R] libs/log: add year to log format ( #2707 )
...
* add year to log format
* update documentation
2018-10-30 11:46:55 -04:00
Zarko Milosevic
7b88172f41
Implement BFT time ( #2203 )
...
* Implement BFT time
* set LastValidators when creating state in state helper
for heights >= 2
2018-08-31 19:33:51 -04:00
Ethan Buchman
d55243f0e6
fix import paths
2018-07-01 22:36:49 -04:00
Ethan Buchman
ae3bf81833
mv tmlibs files to libs dir
2018-07-01 22:36:03 -04:00