Marko
9379bc92fd
fix lint failures with 1.31 ( #5489 )
2020-10-22 13:36:08 +02:00
Marko
6ccccb0933
lint: errcheck ( #5091 )
...
## Description
add more error checks to tests
gonna do a third PR that tackles the non test cases
2020-07-14 11:04:41 +00:00
Marko
9bd0f9e634
lint: golint issue fixes ( #4258 )
...
* lint: golint issue fixes
- on my local machine golint is a lot stricter than the bot so slowly going through and fixing things.
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com >
* more fixes from golint
* remove isPeerPersistentFn
* add changelog entry
2019-12-17 13:02:45 +01:00
Marko
afc4d7a61f
libs/common: refactor libs/common 2 ( #4231 )
...
* libs/common: refactor libs/common 2
- move random function to there own pkg
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com >
* change imports and usage throughout repo
* fix goimports
* add changelog entry
2019-12-10 18:38:34 +01:00
Marko
3e2751d274
lint: Enable Golint ( #4212 )
...
* Fix many golint errors
* Fix golint errors in the 'lite' package
* Don't export Pool.store
* Fix typo
* Revert unwanted changes
* Fix errors in counter package
* Fix linter errors in kvstore package
* Fix linter error in example package
* Fix error in tests package
* Fix linter errors in v2 package
* Fix linter errors in consensus package
* Fix linter errors in evidence package
* Fix linter error in fail package
* Fix linter errors in query package
* Fix linter errors in core package
* Fix linter errors in node package
* Fix linter errors in mempool package
* Fix linter error in conn package
* Fix linter errors in pex package
* Rename PEXReactor export to Reactor
* Fix linter errors in trust package
* Fix linter errors in upnp package
* Fix linter errors in p2p package
* Fix linter errors in proxy package
* Fix linter errors in mock_test package
* Fix linter error in client_test package
* Fix linter errors in coretypes package
* Fix linter errors in coregrpc package
* Fix linter errors in rpcserver package
* Fix linter errors in rpctypes package
* Fix linter errors in rpctest package
* Fix linter error in json2wal script
* Fix linter error in wal2json script
* Fix linter errors in kv package
* Fix linter error in state package
* Fix linter error in grpc_client
* Fix linter errors in types package
* Fix linter error in version package
* Fix remaining errors
* Address review comments
* Fix broken tests
* Reconcile package coregrpc
* Fix golangci bot error
* Fix new golint errors
* Fix broken reference
* Enable golint linter
* minor changes to bring golint into line
* fix failing test
* fix pex reactor naming
* address PR comments
2019-12-05 10:12:08 +01:00
Anton Kaliaev
3e1516b624
linters: enable stylecheck ( #4153 )
...
Refs #3262
2019-11-16 19:35:39 +04:00
Phil Salant
04d13d9945
fix linter errors thrown by unconvert, goconst, and nakedret ( #3960 )
...
* Remove unnecessary type conversions
* Consolidate repeated strings into consts
* Clothe return statements
* Update blockchain/v1/reactor_fsm_test.go
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com >
This PR repairs linter errors seen when running the following commands:
golangci-lint run --no-config --disable-all=true --enable=unconvert
golangci-lint run --no-config --disable-all=true --enable=goconst
golangci-lint run --no-config --disable-all=true --enable=nakedret
Contributes to #3262
2019-09-10 11:31:44 +04:00
Ethan Buchman
ed4ce5ff6c
ADR-016: Update ABCI Info method for versions ( #2662 )
...
* abci: update RequestInfo for versions
* abci: update ResponseInfo for versions
* compile fix
* fix test
* software_version -> version
* comment fix
* update spec
* add test
* comments and fix test
2018-10-18 16:51:17 -04:00
Dev Ojha
2756be5a59
libs: Remove usage of custom Fmt, in favor of fmt.Sprintf ( #2199 )
...
* libs: Remove usage of custom Fmt, in favor of fmt.Sprintf
Closes #2193
* Fix bug that was masked by custom Fmt!
2018-08-10 09:25:57 +04:00
Anton Kaliaev
96ae535fb8
proto3 timestamp ( #2064 )
...
This PR changes ABCI time format from int64 (Unix seconds) to WKT (WellKnownType) google.protobuf.Timestamp.
Refs #1857
Reasons:
better precision
standard DT for proto
* update Gopkg.lock
* [makefile] remove extra grep
- go list excludes vendor by default now
* proto3 timestamp
* [docs/abci-spec] note about serialisation format
* make time non-nullable
2018-07-27 04:23:19 +02:00
Ethan Buchman
d55243f0e6
fix import paths
2018-07-01 22:36:49 -04:00
Alexander Simmerl
a605b66c5a
Move abci imports
2018-06-22 07:28:07 +02:00
Zach
2cc63069c6
rename dummy to kvstore ( #1223 )
...
* remove accidental binary
* docs: s/Dummy&dummy/KVStore&kvstore/g
* glide update to abci
* update abci import paths
* dummy begone, hello kvstore
* RequestInitChain needs genesisBytes
* glide update
2018-02-27 18:01:10 +04:00
Anton Kaliaev
f65e357d2b
adapt Tendermint to new abci.Client interface
...
which was introduced in https://github.com/tendermint/abci/pull/130
2017-11-29 14:23:44 -06:00
Anton Kaliaev
69b5da766c
service#Start, service#Stop signatures were changed
...
See https://github.com/tendermint/tmlibs/issues/45
2017-11-29 10:38:58 -06:00
Zach Ramsay
57ea4987f7
linting: apply errcheck part1
2017-11-27 22:39:11 +00:00
Ethan Buchman
8311f5c611
abci.Info takes a struct; less merkleeyes
2017-09-22 11:42:40 -04:00
Anton Kaliaev
91dc87e7c4
update for a new ABCI API
2017-05-16 19:06:35 +02:00
Ethan Buchman
fcf78a5da7
cleanup go-config/viper and some unnamed imports
2017-04-25 14:54:56 -04:00
Ethan Buchman
d1926bcad1
use tmlibs
2017-04-21 18:12:54 -04:00
Ethan Buchman
c147b41013
TMSP -> ABCI
2017-01-12 15:53:32 -05:00
Ethan Buchman
2dd7030579
tmsp: ResponseInfo and ResponseEndBlock
2017-01-12 15:21:20 -05:00
Jae Kwon
3000c8b349
Update glide w/ TMSP updates
2016-12-06 04:04:08 -08:00
Ethan Buchman
f37f56d4f1
fixes
2016-11-16 13:25:13 -05:00
Ethan Buchman
caeda30b72
proxy: wrap NewTMSPClient in ClientCreator
2016-09-10 17:19:47 -04:00
Ethan Buchman
035ca7ef61
proxy: NewAppConns takes a NewTMSPClient func
2016-09-09 23:55:24 -04:00
Ethan Buchman
3a7ee13ece
proxy: typed app conns
2016-08-24 01:45:45 -04:00
