mergify[bot]
e914fe40ec
ci: Fix linter complaint (backport #9645 ) ( #9647 )
...
* ci: Fix linter complaint (#9645 )
Fixes a very silly linter complaint that makes absolutely no sense and is blocking the merging of several PRs.
---
#### PR checklist
- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
documentation updates needed
(cherry picked from commit 83b7f4ad5b )
# Conflicts:
# .github/workflows/lint.yml
# .golangci.yml
# cmd/tendermint/commands/debug/util.go
* Resolve conflicts
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* ci: Sync golangci-lint config with main
Minus the spelling configuration that restricts spelling to US English
only.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* make format
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove usage of deprecated io/ioutil package
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove unused mockBlockStore
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* blockchain/v2: Remove unused method
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Bulk fix lints
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* lint: Ignore auto-generated query PEG
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Signed-off-by: Thane Thomson <connect@thanethomson.com >
Co-authored-by: Thane Thomson <connect@thanethomson.com >
2022-10-29 08:58:18 -04:00
mergify[bot]
5164dc6d7d
feat: support HTTPS inside websocket (backport #9416 ) ( #9423 )
2022-09-13 11:13:02 +02:00
samricotta
dad439f115
Bump linter to 1.47 ( #9218 )
...
*bump linter to 1.47
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com >
2022-08-11 15:53:17 +02:00
Joe Abbey
4a1df4911d
fix: "Lazy" Stringers to defer Sprintf and Hash until logs print ( #8845 )
2022-06-23 14:56:34 -04:00
Sam Kleinman
4ef140f6ca
lint: cleanup pending lint errors ( #7237 )
2021-11-04 08:08:55 -04:00
mergify[bot]
b7a4d5e7ba
fix: jsonrpc url parsing and dial function ( #6264 ) ( #6288 )
...
This PR fixes how the jsonrpc parses the URL, and how the dial function connects to the RPC.
Closes: https://github.com/tendermint/tendermint/issues/6260
(cherry picked from commit 9ecfcc93a6 )
Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com >
2021-03-29 11:05:03 +00:00
Callum Waters
b021ad5b7a
test: don't use foo-bar.net in TestHTTPClientMakeHTTPDialer ( #5997 ) ( #6047 )
...
This test relied on connecting to the external site `foo-bar.net`, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead.
Co-authored-by: Erik Grinaker <erik@interchain.berlin >
2021-02-04 13:11:07 +04:00
Aleksandr Bezobchuk
53463b3fef
rpc: fix content-type header
2020-11-16 10:54:34 -05:00
Marko
9379bc92fd
fix lint failures with 1.31 ( #5489 )
2020-10-22 13:36:08 +02:00
Anton Kaliaev
85a4be87a7
rpc/client: take context as first param ( #5347 )
...
Closes #5145
also applies to light/client
2020-09-23 09:21:57 +04:00
Marko
b8d08b9ef4
lint: add errchecks ( #5316 )
...
## Description
Work towards enabling errcheck
ref #5059
2020-09-04 11:58:03 +00:00
Marko
2ac5a559b4
libs: wrap mutexes for build flag with godeadlock ( #5126 )
...
## Description
This PR wraps the stdlib sync.(RW)Mutex & godeadlock.(RW)Mutex. This enables using go-deadlock via a build flag instead of using sed to replace sync with godeadlock in all files
Closes : #3242
2020-07-20 07:55:09 +00:00
Marko
7e2cc1db5e
linter: (1/2) enable errcheck ( #5064 )
...
## Description
partially cleanup in preparation for errcheck
i ignored a bunch of defer errors in tests but with the update to go 1.14 we can use `t.Cleanup(func() { if err := <>; err != nil {..}}` to cover those errors, I will do this in pr number two of enabling errcheck.
ref #5059
2020-07-01 15:13:11 +00:00
Erik Grinaker
ba3a2dde37
rpc: replace Amino with new JSON encoder ( #4968 )
...
Migrates the `rpc` package to use new JSON encoder in #4955 . Branched off of that PR.
Tests pass, but I haven't done any manual testing beyond that. This should be handled as part of broader 0.34 testing.
2020-06-08 12:04:05 +00:00
Marko
9149ee7d8b
lint: various fixes
...
## Description
various linitng fixes
2020-05-18 10:20:06 +00:00
Anton Kaliaev
a14ff5cb30
rpc: refactor lib folder ( #4836 )
...
Closes https://github.com/tendermint/tendermint/issues/3857
Moves `lib/` folder to `jsonrpc/`.
Renames:
**packages**
`rpc` package -> `jsonrpc` package
`rpcclient` package -> `client` package
`rpcserver` package -> `server` package
**structs and interfaces**
```
JSONRPCClient to Client
JSONRPCRequestBatch to RequestBatch
JSONRPCCaller to Caller
```
**functions**
```
StartHTTPServer to Serve
StartHTTPAndTLSServer to ServeTLS
rpc/jsonrpc/client: rename NewURIClient to NewURI
NewJSONRPCClient to New
NewJSONRPCClientWithHTTPClient to NewWithHTTPClient
NewWSClient to NewWS
```
**misc**
- unexpose `ResponseWriterWrapper`
- remove unused http_params.go
2020-05-13 16:40:57 +04:00