Thane Thomson
51f87b6074
Apply suggestions from code review
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-05-04 08:31:27 -04:00
Thane Thomson
91d076a6cc
Merge changes from master and resolve conflicts
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-30 14:37:13 -04:00
Thane Thomson
e7451a43e7
blocksync: Honor contexts supplied to BlockPool ( #8447 )
...
* Lift condition into for loop
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Honor contexts in BlockPool
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Only stop timers when necessary
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Optimize timers
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Simplify request interval definition
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Remove extraneous timer stop
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Convert switch into if
Signed-off-by: Thane Thomson <connect@thanethomson.com >
* Eliminate timers
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-30 14:34:59 -04:00
Thane Thomson
fba6848f6c
Isolate TODO more clearly
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-29 17:51:01 -04:00
Thane Thomson
dc6a208f1d
Expand on comment for PeekTwoBlocks for posterity
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-29 17:49:35 -04:00
Thane Thomson
82dd779e93
Lift termination condition into for loop
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-29 14:43:49 -04:00
Sergio Mena
f18f1cb3db
BlockStore holds extended commit
...
Cherry-pick 8d504d4b50ec6afbdffe2df7ababbef30e15053d and fix conflicts.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-04-28 17:12:20 -04:00
Sam Kleinman
07b46d5a05
blocksync: drop redundant shutdown mechanisms ( #8136 )
2022-03-17 13:30:13 -04:00
JayT106
d9c9675e2a
p2p+flowrate: rate control refactor ( #7828 )
...
Adding `CurrentTransferRate ` in the flowrate package because only the status of the transfer rate has been used.
2022-03-10 13:48:23 +00:00
Sam Kleinman
be83ec6664
p2p: pass start time to flowrate and cleanup constructors ( #7838 )
...
After poking around #7828 , I saw the oppertunity for this cleanup,
which I think is both reasonable on its own, and quite low impact, and
removes the math around process start time.
2022-02-18 13:30:19 +00:00
Sam Kleinman
28d34d635c
service: change stop interface ( #7816 )
2022-02-17 11:23:32 -05:00
Sam Kleinman
3c8955e4b8
errors: formating cleanup ( #7507 )
2022-01-04 16:11:28 -05:00
Sam Kleinman
2ff962a63a
log: dissallow nil loggers ( #7445 )
2021-12-14 12:45:13 -05:00
Sam Kleinman
d0e03f01fc
sync: remove special mutexes ( #7438 )
2021-12-13 13:35:32 -05:00
Sam Kleinman
a62ac27047
service: remove exported logger from base implemenation ( #7381 )
2021-12-06 10:16:42 -05:00
Sam Kleinman
a823d167bc
service: cleanup base implementation and some caller implementations ( #7301 )
2021-12-01 09:28:06 -05:00
Sam Kleinman
6ab62fe7b6
service: remove stop method and use contexts ( #7292 )
2021-11-18 17:56:21 -05:00
Sam Kleinman
d7606777cf
libs/service: pass logger explicitly ( #7288 )
...
This is a very small change, but removes a method from the
`service.Service` interface (a win!) and forces callers to explicitly
pass loggers in to objects during construction rather than (later)
injecting them. There's not a real need for this kind of lazy
construction of loggers, and I think a decent potential for confusion
for mutable loggers.
The main concern I have is that this changes the constructor API for
ABCI clients. I think this is fine, and I suspect that as we plumb
contexts through, and make changes to the RPC services there'll be a
number of similar sorts of changes to various (quasi) public
interfaces, which I think we should welcome.
2021-11-16 16:20:56 +00:00
Sam Kleinman
b15b2c1b78
flowrate: cleanup unused files ( #7158 )
...
I saw one of these tests fail and it looks like it was using code that
wasn't being called anywhere, so I deleted it, and avoided the package
name aliasing.
2021-10-26 16:11:34 +00:00
Marko
66a11fe527
blocksync: remove v0 folder structure ( #7128 )
...
Remove v0 blocksync folder structure.
2021-10-15 13:03:53 +00:00
