Sam Kleinman
692701a551
abci: socket server shutdown response handler ( #7547 )
2022-01-10 16:26:40 -05:00
Sam Kleinman
5c0abb5367
testing: use scoped logger for all public packages ( #7504 )
2022-01-04 12:56:17 -05:00
Sam Kleinman
6ab62fe7b6
service: remove stop method and use contexts ( #7292 )
2021-11-18 17:56:21 -05:00
Sam Kleinman
d7606777cf
libs/service: pass logger explicitly ( #7288 )
...
This is a very small change, but removes a method from the
`service.Service` interface (a win!) and forces callers to explicitly
pass loggers in to objects during construction rather than (later)
injecting them. There's not a real need for this kind of lazy
construction of loggers, and I think a decent potential for confusion
for mutable loggers.
The main concern I have is that this changes the constructor API for
ABCI clients. I think this is fine, and I suspect that as we plumb
contexts through, and make changes to the RPC services there'll be a
number of similar sorts of changes to various (quasi) public
interfaces, which I think we should welcome.
2021-11-16 16:20:56 +00:00
Sam Kleinman
9dfdc62eb7
proxy: move proxy package to internal ( #6953 )
2021-09-20 15:18:48 -04:00
Marko
3e2751d274
lint: Enable Golint ( #4212 )
...
* Fix many golint errors
* Fix golint errors in the 'lite' package
* Don't export Pool.store
* Fix typo
* Revert unwanted changes
* Fix errors in counter package
* Fix linter errors in kvstore package
* Fix linter error in example package
* Fix error in tests package
* Fix linter errors in v2 package
* Fix linter errors in consensus package
* Fix linter errors in evidence package
* Fix linter error in fail package
* Fix linter errors in query package
* Fix linter errors in core package
* Fix linter errors in node package
* Fix linter errors in mempool package
* Fix linter error in conn package
* Fix linter errors in pex package
* Rename PEXReactor export to Reactor
* Fix linter errors in trust package
* Fix linter errors in upnp package
* Fix linter errors in p2p package
* Fix linter errors in proxy package
* Fix linter errors in mock_test package
* Fix linter error in client_test package
* Fix linter errors in coretypes package
* Fix linter errors in coregrpc package
* Fix linter errors in rpcserver package
* Fix linter errors in rpctypes package
* Fix linter errors in rpctest package
* Fix linter error in json2wal script
* Fix linter error in wal2json script
* Fix linter errors in kv package
* Fix linter error in state package
* Fix linter error in grpc_client
* Fix linter errors in types package
* Fix linter error in version package
* Fix remaining errors
* Address review comments
* Fix broken tests
* Reconcile package coregrpc
* Fix golangci bot error
* Fix new golint errors
* Fix broken reference
* Enable golint linter
* minor changes to bring golint into line
* fix failing test
* fix pex reactor naming
* address PR comments
2019-12-05 10:12:08 +01:00
Alexander Simmerl
a605b66c5a
Move abci imports
2018-06-22 07:28:07 +02:00
Alexander Simmerl
4bee228ba7
Add abci repo
2018-06-22 02:36:54 +02:00
