Anton Kaliaev
6941d1bb35
use nolint label instead of commenting
2019-02-06 18:21:32 +04:00
Anton Kaliaev
3c8156a55a
preallocating memory when we can
2019-02-06 15:24:54 +04:00
Anton Kaliaev
ffd3bf8448
remove or comment out unused code
2019-02-06 15:16:38 +04:00
Anton Kaliaev and GitHub
d470945503
update gometalinter to 3.0.0 ( #3233 )
...
in the attempt to fix https://circleci.com/gh/tendermint/tendermint/43165
also
code is simplified by running gofmt -s .
remove unused vars
enable linters we're currently passing
remove deprecated linters
2019-01-30 12:24:26 +04:00
Thane Thomson and Anton Kaliaev
a335caaedb
alias amino imports ( #3219 )
...
As per conversation here: https://github.com/tendermint/tendermint/pull/3218#discussion_r251364041
This is the result of running the following code on the repo:
```bash
find . -name '*.go' | grep -v 'vendor/' | xargs -n 1 goimports -w
```
2019-01-28 16:13:17 +04:00
Dev Ojha and Ethan Buchman
55d7238708
Add comment to simple_merkle get_split_point ( #3136 )
...
* Add comment to simple_merkle get_split_point
* fix grammar error
2019-01-16 16:03:19 -05:00
Dev Ojha and Ethan Buchman
ec53ce359b
Simple merkle rfc compatibility ( #2713 )
...
* Begin simple merkle compatibility PR
* Fix query_test
* Use trillian test vectors
* Change the split point per RFC 6962
* update spec
* refactor innerhash to match spec
* Update changelog
* Address @liamsi's comments
* Write the comment requested by @liamsi
2019-01-13 18:02:38 -05:00
Jae Kwon and Ethan Buchman
03e42d2e38
Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa… ( #2756 )
...
* Fix crypto/merkle ProofOperators.Verify to check bounds on keypath parts.
* Update PENDING
2018-11-05 22:53:44 -08:00
Ethan Buchman and GitHub
a22c962e28
TMHASH is 32 bytes. Closes #1990 ( #2732 )
...
* tmhash is fully 32 bytes. closes #1990
* AddressSize
* fix tests
* fix max sizes
2018-10-31 12:42:05 -04:00
Jae Kwon and Ethan Buchman
1660e30ffe
Fix general merkle keypath to start w/ last op's key ( #2733 )
...
* Fix general merkle keypath to start w/ last op's key
* Update CHANGELOG_PENDING.md
2018-10-31 11:02:13 -04:00
Ismail Khoffi and Ethan Buchman
6643c5dd11
Catch up with amino 0.13.0 ( #2690 )
...
* catch up with amino changes in
https://github.com/tendermint/go-amino/pull/222
* WIP: update to amino v0.13.0
* update to fixed amino release
2018-10-24 21:34:01 -04:00
Dev Ojha and Ethan Buchman
124d0db1e0
Make txs and evidencelist use merkle.SimpleHashFromBytes to create hash ( #2635 )
...
This is a performance regression, but will also spare the types directory
from knowing about RFC 6962, which is a more correct abstraction. For txs
this performance hit will be fixed soon with #2603 . For evidence, the
performance impact is negligible due to it being capped at a small number.
2018-10-15 16:42:47 -04:00
Dev Ojha and Ethan Buchman
1b51cf3f46
Remove unnecessary layer of indirection / unnecessary allocation of hashes ( #2620 )
2018-10-12 17:48:00 -04:00
Dev Ojha and Ethan Buchman
12fa9d1cab
crypto/merkle: Remove byter in favor of plain byte slices ( #2595 )
...
* crypto/merkle: Remove byter in favor of plain byte slices
This PR is fully backwards compatible in terms of function output!
(The Go API differs though) The only test case changes was to refactor
it to be table driven.
* Update godocs per review comments
2018-10-10 12:46:09 -04:00
Ethan Buchman and GitHub
f36ed7e7ff
General Merkle Follow Up ( #2510 )
...
* tmlibs -> libs
* update changelog
* address some comments from review of #2298
2018-09-28 23:32:13 -04:00
Joon and Ethan Buchman
71a34adfe5
General Merkle Proof ( #2298 )
...
* first commit
finalize rebase
add protoc_merkle to Makefile
* in progress
* fix kvstore
* fix tests
* remove iavl dependency
* fix tx_test
* fix test_abci_cli
fix test_apps
* fix test_apps
* fix test_cover
* rm rebase residue
* address comment in progress
* finalize rebase
2018-09-28 20:03:19 -04:00
Dev Ojha and Anton Kaliaev
2756be5a59
libs: Remove usage of custom Fmt, in favor of fmt.Sprintf ( #2199 )
...
* libs: Remove usage of custom Fmt, in favor of fmt.Sprintf
Closes #2193
* Fix bug that was masked by custom Fmt!
2018-08-10 09:25:57 +04:00
Ethan Buchman
d55243f0e6
fix import paths
2018-07-01 22:36:49 -04:00
Anton Kaliaev
61c5791fa3
revert back to Jae's original payload size limit
...
except now we calculate the max size using the maxPacketMsgSize()
function, which frees developers from having to know amino encoding
details.
plus, 10 additional bytes are added to leave the room for amino upgrades
(both making it more efficient / less efficient)
2018-06-29 12:57:17 +04:00
Liamsi
c96b27136f
remove go-crypto from go-crypto:
...
use tendermint/crypto :-)
2018-06-20 21:05:38 -07:00
Liamsi
368c236c75
mv go-crypto files to crypto dir
2018-06-20 15:30:44 -07:00