5 Commits

Author	SHA1	Message	Date
Sam Kleinman	6ab62fe7b6	service: remove stop method and use contexts (#7292)	2021-11-18 17:56:21 -05:00
Sam Kleinman	d7606777cf	libs/service: pass logger explicitly (#7288) ... This is a very small change, but removes a method from the `service.Service` interface (a win!) and forces callers to explicitly pass loggers in to objects during construction rather than (later) injecting them. There's not a real need for this kind of lazy construction of loggers, and I think a decent potential for confusion for mutable loggers. The main concern I have is that this changes the constructor API for ABCI clients. I think this is fine, and I suspect that as we plumb contexts through, and make changes to the RPC services there'll be a number of similar sorts of changes to various (quasi) public interfaces, which I think we should welcome.	2021-11-16 16:20:56 +00:00
Sam Kleinman	63192ac300	consensus: remove stale WAL benchmark (#7194)	2021-11-03 07:01:46 -04:00
Sam Kleinman	a6b30faf35	libs/time: move types/time into libs (#6595)	2021-06-17 16:02:31 -04:00
Sam Kleinman	a855f96946	p2p: renames for reactors and routing layer internal moves (#6547)	2021-06-08 08:17:09 -04:00