* p2p: add a per-message type send and receive metric (#9622)
* p2p: ressurrect the p2p envelope and use to calculate message metric
Add new SendEnvelope, TrySendEnvelope, BroadcastEnvelope, and ReceiveEnvelope methods in the p2p package to work with the new envelope type.
Care was taken to ensure this was performed in a non-breaking manner.
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
Co-authored-by: William Banfield <wbanfield@gmail.com>
* security/p2p: prevent peers who errored being added to the peer_set (#9500)
* Mark failed removal of peer to address security bug
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
(cherry picked from commit c0bdb2423a)
* Changelong entry and added missing functions for implementations of Peer
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
* Ignore generated/copied RPC docs
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Sync vuepress config with main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Sync docs package-lock.json with main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Sync docs redirects with main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Sync docs versions with main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update OpenAPI version to v0.34
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Sync DOCS_README with main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update all v0.34.x docs references from master to main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update v0.34 OpenAPI references from master to main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update repo doc links from master to main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update code comment references from master to main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update repo root doc links from master to main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update repo root doc links for docs.tendermint.com from master to main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Build v0.34.x as "latest"
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Explicitly mark v0.34 docs as latest in version selector
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Add nav link to main and clearly mark as unstable
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Direct all docs.tendermint.com links to v0.34 on v0.34.x
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update all relevant links on v0.34.x branch to be v0.34-specific
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update changelog refs to docs.tendermint.com
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Update remaining GH master link to main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Sync docs build and nav config with main
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Migrate spec links to GitHub repo from docs site
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Initial commit
* Add three timeouts and align pseudocode better with existing algorithm
* Align protocol with Tendermint code and add find valid value mechanism
* Prepare to Nuke Develop (#47)
* state -> step
* vote -> v
* New version of the algorithm and the proof
* New version of the algorithm and the proofs
* Added algorithm description
* Add algorithm description
* Add introduction
* Add conclusion
* Add conclusion file
* fix warnings (caption was defined twice)
- only the latter is used anyways (centers captions)
- this makes it possible to autom. building the paper
* Update grammar
* s/state_p/step_p
* Address Ismail's comments
* intro: language fixes
* definitions: language fixes
* consensus: various fixes
* proof: some fixes
* try to improve reviewability
* \eq -> =
* textwrap to 79
* various minor fixes
* proof: fix itemization
* proof: more minor fixes
* proof: timeouts are functions
* proof: fixes to lemma6
* Intro changes and improve title page
* Add Marko and Ming to acks
* add readme
* Format algorithm correctly
Clarify condition semantic and timeouts
Improve descriptions
* patform -> platform
* Ensure that rules are mutually exclusive
- various clarifications and small improvements
* Release v0.6
* small nits for smoother readability
* This PR is to create signed commits to be able to merge (#50)
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* Add consesnus and blockchain specs, (#52)
- Open questions
- Do we want to split lite client work from consesnsus
- From the blockchain spec, is encoding nessecary in the spec
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* Add ABCI SPEC (#51)
- move the abci spec from tendermint to spec repo
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* spec/consensus/signing: add more details about nil and amnesia (#54)
- Add more details about nil votes and about amnesia attacks
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* Add Section for P2P (#53)
* Add Section for P2P
- moved over the section on p2p
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* add some more files
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* Fix model section
* Add non-recursive specification of Bisection algorithm
- Fix timing issues by introducing Delta parameter
* spec: update spec with tendermint updates (#62)
* spec: update spec with tendermint updates
- this in preperation of deleting the spec folder in docs in tendermint/tendermint
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* spec: added in reactors & p2p
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* spec: update readme in spec to comply with docs site
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* docs: addded more changes from tednermint/tendermint
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* reflect breaking changes made to Commit (#63)
* reflect breaking changes made to Commit
PR: https://github.com/tendermint/tendermint/pull/4146
Issue: https://github.com/tendermint/tendermint/issues/1648
* types: rename Commit#Precommits to Signatures
* update BlockIDFlagAbsent comment
* remove iota
* Clean up error conditions and simplify pseudocode
* Apply suggestions from code review
Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com>
* Add spec doc about unconditional_peer, persistent_peers_max_dial of ADR-050 (#68)
* Add spec doc about unconditional_peer_ids, persistent_peers_max_dial_period of ADR-050
* Add indefinitely dialing condition
* Add sr25519 amino documentation (#67)
* sr25519 amino
* Update spec/blockchain/encoding.md
Co-Authored-By: Marko <marbar3778@yahoo.com>
* some suggestions for pseuodocode changes
* Improved error handling
* Add explanation on difference between trusted models
* Address reviewer's comments
* Addressing reviewer's comments
* Separating algorithm from proofs
* Intermediate commit (aligning spec with the code)
* Removing Store from API and providing end-to-end timing guarantees
* Address reviewer comment's. Intermediate commit
* light client dir and readmes
* titles
* add redirects
* add diagram
* detection TODO
* fix image
* update readme
* Aligh the correctness arguments with the pseudocode changes
* lite->light
* Fix link in readme
./light -> ./light-client
* p2p: Merlin based malleability fixes (#72)
* Update the secret connection spec with the use of merlin to eliminte handshake malleability
* Update spec/p2p/peer.md
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
* Update spec/p2p/peer.md
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
* Update spec/p2p/peer.md
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
* docs: update specs to remove cmn (#77)
- cmn was remvoed in favor of sub pkgs. cmn.kvpair is now kv.pair
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* evidence: Add time to evidence params (#69)
* evidence: Add time to evidence params
- this pr is grouped together with https://github.com/tendermint/tendermint/pull/4254, once that PR is merged then this one can be as well.
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* remove note
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* Apply suggestions from code review
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
* update link to the pex reactor
* add markdown link checker
* changed tab spacing
* removed folder-path flag
* first attempt at fixing all links
* second attempt at fixing all links
* codeowners: add code owners (#82)
* codeowners: add code owners
- added some codeowners
please comment if youd like to be added as well.
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* remove comment of repo maintainers
* remove .idea dir (#83)
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* RFC-001: configurable block retention (#84)
* Added RFC for truncated block history coordination
* Clarified minimum block retention
* Added hard checks on block retention and snapshot interval, and made some minor tweaks
* Genesis parameters are immutable
* Use local config for snapshot interval
* Reordered parameter descriptions
* Clarified local config option for snapshot-interval
* rewrite for ABCI commit response
* Renamed RFC
* add block retention diagram
* Removed retain_blocks table
* fix image numbers
* resolved open questions
* image quality
* accept RFC-001 (#86)
* abci: add basic description of ABCI Commit.ResponseHeight (#85)
Documentation for block pruning, once it's merged: tendermint/tendermint#4588.
Minimum documentation, for now - we probably shouldn't encourage using this feature too much until we release state sync.
* abci: add MaxAgeNumBlocks/MaxAgeDuration to EvidenceParams (#87)
* abci: update MaxAgeNumBlocks & MaxAgeDuration docs (#88)
* document state sync ABCI interface and P2P protocol (#90)
The corresponding Tendermint PRs are tendermint/tendermint#4704 and tendermint/tendermint#4705.
* Revert "document state sync ABCI interface and P2P protocol (#90)" (#92)
This reverts commit 9842b4b0fb.
* blockchain: change validator set sorting method (#91)
* abci: specify sorting of RequestInitChain.Validators
* blockchain: change validator sorting method
Refs https://github.com/tendermint/tendermint/issues/2478
* reactors/pex: specify hash function (#94)
https://github.com/tendermint/tendermint/pull/4810/files
* document state sync ABCI interface and P2P protocol (#93)
* Revert "Revert "document state sync ABCI interface and P2P protocol (#90)" (#92)"
This reverts commit 90797cef90.
* update with new enum case
* fix links
Co-authored-by: Erik Grinaker <erik@interchain.berlin>
* Update evidence params with MaxNum (#95)
evidence params now includes maxNum which is the maximum number of evidence that can be committed on a single block
* reactors/pex: masked IP is used as group key (#96)
* spec: add ProofTrialPeriod to EvidenceParam (#99)
* spec: modify Header.LastResultsHash (#97)
Refs: https://github.com/tendermint/tendermint/issues/1007
PR: https://github.com/tendermint/tendermint/pull/4845
* spec: link to abci server implementations (#100)
* spec: update evidence in blockchain.md (#108)
now evidence reflects the actual evidence present in the tendermint repo
* abci: add AppVersion to ConsensusParams (#106)
* abci: tweak node sync estimate (#115)
* spec/abci: expand on Validator#Address (#118)
Refs https://github.com/tendermint/tendermint/issues/3732
* blockchain: rename to core (#123)
* blockchain: remove duplicate evidence sections (#124)
* spec/consensus: canonical vs subjective commit
Refs https://github.com/tendermint/tendermint/issues/2769
* Apply suggestions from code review
Co-authored-by: Igor Konnov <igor.konnov@gmail.com>
* update spec with the removal of phantom validator evidence (#126)
* bring blockchain back
* add correct links
* spec: revert event hashing (#132)
* Evidence time is sourced from block time (#138)
* RFC-002: non-zero genesis (#119)
* abci: add ResponseInitChain.app_hash (#140)
* update hashing of empty inputs, and initial block LastResultsHash (#141)
* update evidence verification (#139)
* accept RFC-002 (#142)
* add description of arbitrary initial height (#135)
* update ResponseInitChain.app_hash description (#143)
* remove unused directories and update README (#145)
This change removes unused directories (`papers` and `research`)
and updates the README to reflect our strategy for merging the
informalsystems/tendermint-rs specs into this repository.
Partially addresses #121.
* ci: add markdown linter (#146)
* ci: add dependabot config (#148)
* build(deps): bump gaurav-nelson/github-action-markdown-link-check from 0.6.0 to 1.0.7 (#149)
Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 0.6.0 to 1.0.7.
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: add sections to abci (#150)
* spec: update abci events (#151)
* spec: extract light-client to its own directory (#152)
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* spec: remove evidences (#153)
* add a stale bot (#134)
* Current versions of light client specs from tendermint-rs (#158)
* current versions of light client specs from tendermint-rs
* markdown lint
* linting
* links
* links
* links
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
* Fastsync spec from tendermint-rs (#157)
* fastsync spec from tendermint-rs
* fixed broken link
* fixed linting
* more fixes
* markdown lint
* move fast_sync to rust-spec
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
* Update README.md (#160)
* spec/reactors/mempool: batch txs per peer (#155)
* spec/reactors/mempool: batch txs per peer
Refs https://github.com/tendermint/tendermint/issues/625
* update
* spec: Light client attack detector (#164)
* start with new detection and evidence spec
* more definitions at top
* sketch of functions
* pre post draft
* evidence proof
* typo
* evidence theory polished
* some TODOs resolved
* more TODOs
* links
* second to last revision before PR
* links
* I will read once more and then make a PR
* removed peer handling definitions
* secondary
* ready to review
* detector ready for review
* Update rust-spec/lightclient/detection/detection.md
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
* Update rust-spec/lightclient/detection/detection.md
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
* Update rust-spec/lightclient/detection/detection.md
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
* Update rust-spec/lightclient/detection/detection.md
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
* Update rust-spec/lightclient/detection/detection.md
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
* Update rust-spec/lightclient/detection/detection.md
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
* Update rust-spec/lightclient/detection/detection.md
* skip-trace
* PossibleCommit explained
* Update rust-spec/lightclient/detection/detection.md
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
* comments by Zarko
* renamed and changed link in README
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
* fixed an overlooked conflict (#167)
* describe valset sorting according to v0.34 requirements (#169)
* evidence: update data structures (#165)
* fix markdown linter (#172)
* TLA+ specs from MBT revision (#173)
* remove setOption (#181)
* spec: protobuf changes (#156)
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
* first check latest with secondary (#184)
* Extending the blockchain specification (in the light client) to produce different ratios of faults (#183)
* cleaning unused definitions
* introduced the ratio of faulty processes
* Update README.md (#185)
* build(deps): bump gaurav-nelson/github-action-markdown-link-check from 1.0.7 to 1.0.8 (#188)
Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.7 to 1.0.8.
- [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](https://github.com/gaurav-nelson/github-action-markdown-link-check/compare/1.0.7...e3c371c731b2f494f856dc5de7f61cea4d519907)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* spec: update light client verification to match supervisor (#171)
* VDD renaming of verification spec + links fixed
* latest()
* backwards
* added TODOs
* link in old file to new name
* better text
* revision done. needs one more round of reading
* renamed constants in 001 according to TLA+ and impl
* ready for PR
* forgot linting
* Update rust-spec/lightclient/verification/verification_002_draft.md
* Update rust-spec/lightclient/verification/verification_002_draft.md
* added lightstore function needed for supervisor
* added lightstore functions for supervisor
* ident
* Update rust-spec/lightclient/verification/verification_002_draft.md
* github: issue template for proposals (#190)
* Sequential Supervisor (#186)
* move from tendermint-rs but needs discussion
* markdown lint
* TODO links replaced
* links
* links
* links lint
* Update rust-spec/lightclient/supervisor/supervisor.md
* Update rust-spec/lightclient/supervisor/supervisor.md
* Update rust-spec/lightclient/supervisor/supervisor.md
* Update rust-spec/lightclient/supervisor/supervisor.md
* moved peer handling definitions to supervisor
* polishing
* rename
* Update rust-spec/lightclient/supervisor/supervisor_001_draft.md
* Update rust-spec/lightclient/supervisor/supervisor_001_draft.md
* changes to maintain StateVerified again
* ready for changes in verification
* start of supervisor
* module name
* fixed
* more details
* supevisor completed. Now I have to add function to verification
* ready for review
* tla comment
* removed issues
* Update rust-spec/lightclient/supervisor/supervisor_001_draft.md
* intro text fixed
* indentation
* Update rust-spec/lightclient/supervisor/supervisor_001_draft.md
* comment to entry points
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
* RFC: adopt zip 215 (#144)
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Core: move validation & data structures together (#176)
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* docs: make blockchain not viewable (#211)
* evidence: update data structures to reflect added support of abci evidence (#213)
* encoding: add secp, ref zip215, tables (#212)
* Detector English Spec ready (#215)
Add detector English spec
* add Ivy proofs (#210)
* add Ivy proofs
* fix docker-compose command
* Light client detector spec in TLA+ and refactoring of light client verification TLA+ spec (#216)
Add light client detector spec in TLA+
* abci: lastcommitinfo.round extra sentence (#221)
* abci: add abci_version to requestInfo (#223)
* BFT requires _less than_ 1/3 faulty validators (#228)
Thanks fo spotting the imprecision in the text, @shahankhatch !
* Draft of evidence handling for discussion (#225)
* start with accountability deliverable
* problem statement
* draft function
* quite complete draft. ready to discuss with Igor
* Update isolate-attackers_001_draft.md
* Update isolate-attackers_001_draft.md
* Update isolate-attackers_001_draft.md
* Update isolate-attackers_001_draft.md
* Update isolate-attackers_001_draft.md
* ready for TLA+ to take over
* isolate
* isolateamnesiatodos
* Update isolate-attackers_001_draft.md
* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md
Co-authored-by: Igor Konnov <konnov@forsyte.at>
* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md
Co-authored-by: Igor Konnov <konnov@forsyte.at>
* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md
Co-authored-by: Igor Konnov <konnov@forsyte.at>
* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md
Co-authored-by: Igor Konnov <konnov@forsyte.at>
* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md
Co-authored-by: Igor Konnov <konnov@forsyte.at>
* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md
Co-authored-by: Igor Konnov <konnov@forsyte.at>
* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md
Co-authored-by: Igor Konnov <konnov@forsyte.at>
* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md
Co-authored-by: Igor Konnov <konnov@forsyte.at>
* The TLA+ specification of the attackers detection (#231)
* the working attackers isolation spec, needs more comments
* the TLA+ spec of the attackers isolation
* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#233)
Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.8 to 1.0.11.
- [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](https://github.com/gaurav-nelson/github-action-markdown-link-check/compare/1.0.8...2a60e0fe41b5361f446ccace6621a1a2a5c324cf)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Computing attack types (#232)
Add light attack evidence handling
* Update README.md (#234)
* p2p: update frame size (#235)
Reflect the change made in https://github.com/tendermint/tendermint/pull/5805
The MTU (Maximum Transmission Unit) for Ethernet is 1500 bytes.
The IP header and the TCP header take up 20 bytes each at least (unless
optional header fields are used) and thus the max for (non-Jumbo frame)
Ethernet is 1500 - 20 -20 = 1460
Source: https://stackoverflow.com/a/3074427/820520
* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#239)
Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.11 to 1.0.12.
- [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](https://github.com/gaurav-nelson/github-action-markdown-link-check/compare/1.0.11...0fe4911067fa322422f325b002d2038ba5602170)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* layout: add section titles (#240)
* reactors: remove bcv1 (#241)
* abci: rewrite to proto interface (#237)
* Update supervisor_001_draft.md (#243)
* spec: remove reactor section (#242)
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
* non-critical bugfix in the TLA+ spec (found by new version of apalache) (#244)
* params: remove block timeiota (#248)
* proto: add files (#246)
Co-authored-by: Erik Grinaker <erik@interchain.berlin>
* proto: modify height int64 to uint64 (#253)
* abci: note on concurrency (#258)
Co-authored-by: Marko <marbar3778@yahoo.com>
* spec: merge rust-spec (#252)
* Fix list of RFCs (#266)
* readme: cleanup (#262)
* modify readme
* add rfc and proto
* add rust=spec back to avoid breakage
* lint readme
* genesis: Explain fields in genesis file (#270)
* describe the genesis
* Update spec/core/genesis.md
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* add wording on app_state
* Update spec/core/genesis.md
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* p2p: links (#268)
* fix links
* fix more links
* Proposer-based timestamp specification (#261)
* added proposer-based timestamp spec
* Update spec/consensus/proposer-based-timestamp/pbts_001_draft.md
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update spec/consensus/proposer-based-timestamp/pbts_001_draft.md
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update spec/consensus/proposer-based-timestamp/pbts-algorithm_001_draft.md
Co-authored-by: Marko <marbar3778@yahoo.com>
* Update spec/consensus/proposer-based-timestamp/pbts-algorithm_001_draft.md
* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_001_draft.md
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* fixes from PR
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* abci: reorder sidebar (#282)
* ABCI++ RFC (#254)
* ABCI++ RFC
This commit adds an RFC for ABCI++, which is a collection of three new phases of communication between the consensus engine and the application.
Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch>
* Fix bugs pointed out by @liamsi
* Update rfc/004-abci++.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Fix markdown lints
* Update rfc/004-abci++.md
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
* Update rfc/004-abci++.md
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
* Update rfc/004-abci++.md
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
* Add information about the rename in the context section
* Bold RFC
* Add example for self-authenticating vote data
* More exposition of the term IPC
* Update pros / negatives
* Fix sentence fragment
* Add desc for no-ops
Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
* RFC: ReverseSync - fetching historical data (#224)
* core: update a few sections (#284)
* p2p: update state sync messages for reverse sync (#285)
* Update README.md (#286)
* rpc: define spec for RPC (#276)
* add rpc spec and support outline
* add json
* add more routes remove unneeded ones
* add rest of rpc endpoints
* add jsonrpc calls
* add more jsonrpc calls
* fix blockchain
* cleanup unused links and add links to repos
* Update spec/rpc/README.md
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* add missing param from consensus param
* Update spec/rpc/README.md
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* Update spec/rpc/README.md
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* fix cast and add doc to readme
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Marko Baricevic <markobaricevic@Fergalicious.local>
* A few improvements to the Ivy proof (#288)
* Avoid quantifier alternation cycle
The problematic quantifier alternation cycle arose because the
definition of accountability_violation was unfolded.
This commit also restructures the induction proof for clarity.
* add count_lines.sh
* fix typo and add forgotten complete=fo in comment
Co-authored-by: Giuliano <giuliano@eic-61-11.galois.com>
* Fixed a broken link (#291)
* fix message type for block-sync (#298)
* lint: fix lint errors (#301)
* build(deps): bump actions/stale from 3 to 3.0.18 (#300)
Bumps [actions/stale](https://github.com/actions/stale) from 3 to 3.0.18.
- [Release notes](https://github.com/actions/stale/releases)
- [Commits](https://github.com/actions/stale/compare/v3...v3.0.18)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump actions/stale from 3.0.18 to 3.0.19 (#302)
Bumps [actions/stale](https://github.com/actions/stale) from 3.0.18 to 3.0.19.
- [Release notes](https://github.com/actions/stale/releases)
- [Commits](https://github.com/actions/stale/compare/v3.0.18...v3.0.19)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* rename HasVote to ReceivedVote (#289)
* add a changelog to track changes (#303)
* add a changelog to track changes
* Update CHANGELOG.md
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* rpc: clarify timestamps (#304)
* clarify timestamps
* changelog entry
* Update spec/rpc/README.md
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* rpc: add chunked genesis endpoint (#299)
* rpc: add chunked genesis endpoint
* fix lint
* feedback
* add info about error
* fix lint
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
* update ResponseCheckTx (#306)
* rpc: Add totalGasUSed to block_results response (#308)
* Add C++ code generation and test scenario (#310)
* add parameters to byzantine send action
* make net not trusted
it's not necessary since for proofs Ivy will assume that the environment
does not break action preconditions
* use require instead of assume
it seems that assume is not checked when other isolates call!
* add comment
* add comment
* run with random seed
* make domain model extractable to C++
* substitute require for assume
assumes in an action are not checked when the action is called! I.e.
they place no requirement on the caller; we're just assuming that the
caller is going to do the right thing. This wasn't very important here
but it leade to a minor inconsistency slipping through.
* make the net isolate not trusted
there was no need for it
* add tendermint_test.ivy
contains a simple test scenario that show that the specification is no
vacuuous
* update comment
* add comments
* throw if trying to parse nset value in the repl
* add comment
* minor refactoring
* add new pex messages (#312)
* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#313)
Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.12 to 1.0.13.
- [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](https://github.com/gaurav-nelson/github-action-markdown-link-check/compare/1.0.12...1.0.13)
---
updated-dependencies:
- dependency-name: gaurav-nelson/github-action-markdown-link-check
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update spec to reference currently used timestamp type (#317)
* build(deps): bump actions/stale from 3.0.19 to 4 (#319)
Bumps [actions/stale](https://github.com/actions/stale) from 3.0.19 to 4.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/stale/compare/v3.0.19...v4)
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* address discrepancies between spec and implementation (#322)
* update proto files for release (#318)
* stale bot: ignore issues (#325)
* evidence: add section explaining evidence (#324)
* statesync: new messages for gossiping consensus params (#328)
* rpc: update peer format in specification in NetInfo operation (#331)
* Update supervisor_001_draft.md (#334)
* core: text cleanup (#332)
* abci: clarify what abci stands for (#336)
* abci: clarify what abci stands for
* link to abci type protos.
* abci: clarify connection use in-process (#337)
* abci: clarify connection use in-process
* Update abci.md
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* invert abci explanations
* lint++
* lint++
* lint++
* lint++
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* proto: move proto files under the correct directory related to their package name (#344)
* abci.md fixup (#339)
* abci: points of clarification ahead of v0.1.0
* lint++
* typo
* lint++
* double word score
* grammar
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update spec/abci/abci.md
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* pr feedback
* wip
* update non-zero status code docs
* fix event description
* update CheckTx description
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* Update supervisor_001_draft.md (#333)
* Update supervisor_001_draft.md
If the only node in the *FullNodes* set is the primary, that was just deemed faulty, we can't find honest primary.
* Update supervisor_001_draft.md
* light: update initialization description (#320)
* apps.md fixups (#341)
* wip
* wip
* wip
* remove comments in favor of gh comments
* wip
* udpates to language, should must etc
* Apply suggestions from code review
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* remove tendermint cache description
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
* proto: add tendermint go changes (#349)
* add missed proto files
* add abci changes
* rename blockchain to blocksync
* Update proto/tendermint/abci/types.proto
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
* fix mockery generation script (#9094)
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
Co-authored-by: Milosevic, Zarko <zare.milosevic@gmail.com>
Co-authored-by: Milosevic, Zarko <zare.milosevic@sicpa.com>
Co-authored-by: Zarko Milosevic <zarko@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Zarko Milosevic <zarko@interchain.io>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
Co-authored-by: dongsamb <dongsamb@gmail.com>
Co-authored-by: Sunny Aggarwal <sunnya97@gmail.com>
Co-authored-by: Anca Zamfir <anca@interchain.io>
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Zarko Milosevic <zarko@informal.systems>
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-authored-by: Zaki Manian <zaki@tendermint.com>
Co-authored-by: Erik Grinaker <erik@interchain.berlin>
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>
Co-authored-by: Igor Konnov <igor.konnov@gmail.com>
Co-authored-by: Sean Braithwaite <brapse@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com>
Co-authored-by: Andrey Kuprianov <59489470+andrey-kuprianov@users.noreply.github.com>
Co-authored-by: Igor Konnov <konnov@forsyte.at>
Co-authored-by: Sam Hart <sam@hxrts.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Giuliano <giuliano@losa.fr>
Co-authored-by: Shahan Khatchadourian <shahan.k.code@gmail.com>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: istoilkovska <anili100@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Sam Kleinman <garen@tychoish.com>
Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Marko Baricevic <markobaricevic@Fergalicious.local>
Co-authored-by: Giuliano <giuliano@eic-61-11.galois.com>
Co-authored-by: Jordan Sexton <jordan@jordansexton.com>
Co-authored-by: MengXiangJian <805442788@qq.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
Co-authored-by: crypto-facs <84574577+crypto-facs@users.noreply.github.com>
Co-authored-by: Giuliano <giuliano@galois.com>
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
Co-authored-by: Mateusz Górski <goral09@users.noreply.github.com>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
* p2p/conn: check for channel id overflow before processing receive msg (#6522)
Per tendermint spec, each Channel has a globally unique byte id, which
is mapped to uint8 in Go. However, the proto PacketMsg.ChannelID field
is declared as int32, and when receive the packet, we cast it to a byte
without checking for possible overflow. That leads to a malform packet
with invalid channel id is sent successfully.
To fix it, we just add a check for possible overflow, and return invalid
channel id error.
Fixed#6521
(cherry picked from commit 1f46a4c90e)
After a reactor has failed to parse an incoming message, it shouldn't output the "bad" data into the logs, as that data is unfiltered and could have anything in it. (We also don't think this information is helpful to have in the logs anyways.)
## Description
When downloading mockery I ran into an issue where we were using the old version. This PR updates to a more recent version.
changelog?
Closes: #XXX
## Description
Remove secp256k1 as discussed in the tendermint dev call. The implementation has been moved to the [Cosmos-SDK](443e0c1f89/crypto/keys/secp256k1)
Closes: #XXX
## Description
This PR aims to make the crypto.PubKey interface more intuitive.
Changes:
- `VerfiyBytes` -> `VerifySignature`
Before `Bytes()` was amino encoded, now since it is the byte representation should we get rid of it entirely?
EDIT: decided to keep `Bytes()` as it is useful if you are using the interface instead of the concrete key
Closes: #XXX
## Description
Add test vectors for all reactors
- [x] state-sync
- [x] privval
- [x] mempool
- [x] p2p
- [x] evidence
- [ ] light?
this PR is primarily oriented at testvectors for things going over the wire. should we expand the testvectors into types as well?
Closes: #XXX
While working on tendermint my colleague @jinmannwong fixed a few of the unit tests that we found to be flaky in our CI. We thought that you might find this useful, see below for comments.
Closes#1581
This fixes the error in #1581, and also documents the purpose of this line. It ensures that if a peer tells us an address we know about, whose ID is the same as our current ID, we ignore it.
This removes the previous case where the ID's matched, but the IP's did not, which could yield a potential overwrite of the IP associated with the address later on. (This then would yield an eclipse attack)
This was not a vulnerability before though, thanks to a defensive check here 95fc7e58ee/p2p/pex/addrbook.go (L522))
## Description
This PR wraps the stdlib sync.(RW)Mutex & godeadlock.(RW)Mutex. This enables using go-deadlock via a build flag instead of using sed to replace sync with godeadlock in all files
Closes: #3242
- drop Height & Base from StatusRequest
It does not make sense nor it's used anywhere currently. Also, there
seem to be no trace of these fields in the ADR-40 (blockchain reactor
v2).
- change PacketMsg#EOF type from int32 to bool
## Description
partially cleanup in preparation for errcheck
i ignored a bunch of defer errors in tests but with the update to go 1.14 we can use `t.Cleanup(func() { if err := <>; err != nil {..}}` to cover those errors, I will do this in pr number two of enabling errcheck.
ref #5059
Migrates the p2p connections to Protobuf. Supersedes #4800.
gogoproto's `NewDelimitedReader()` uses an internal buffer, which makes it unsuitable for reading individual messages from a shared reader (since any remaining data in the buffer will be discarded). We therefore add a new `protoio` package with an unbuffered `NewDelimitedReader()`. Additionally, the `NewDelimitedWriter()` returns the number of bytes written, and we've added `MarshalDelimited()` and `UnmarshalDelimited()`, to ease migration of existing code.
