mirror of
https://github.com/tendermint/tendermint.git
synced 2026-02-03 02:22:04 +00:00
4309f54349
* libs/pubsub/query: specify peg version in go.mod The code to generate the pubsub queries was dependent on an unspecified version of the peg tool. This brings peg into go.mod so it is on a fixed version. This should also enable dependabot to notify us of future updates to peg. The version of query.peg.go generated from the current version of peg correctly contains the special "Code generated by..." line to indicate to other tools that the file is automatically generated and should therefore be excluded from linters, etc. I removed the make target as there were no git grep results referencing "gen_query_parser"; directly running "go generate" is a reasonable expectation in Go projects. Now that "go run" is module aware, I would typically use "go run" inside the go:generate directive, but in this case we go build to a gitignore-d directory in order to work around the nondeterministic output detailed in pointlander/peg#129. * libs/pubsub/query: check error from (*QueryParser).Init() The newly generated peg code returns an error from Init(); the previous version was niladic. Co-authored-by: Sam Kleinman <garen@tychoish.com>
8 lines
339 B
Plaintext
8 lines
339 B
Plaintext
# This is a temporary directory to hold the peg binary,
|
|
# to work around https://github.com/pointlander/peg/issues/129.
|
|
# Note that once we have a new version of peg fixing #129,
|
|
# we may still want to keep this .gitignore to prevent anyone
|
|
# from accidentally running "git add ." and including their built
|
|
# peg binary in a commit.
|
|
.bin/
|