M. J. Fromberger 4a9bbe047f Fix lock sequencing in socket client request tracking. (#8581) ...

* Fix lock sequencing in socket client request tracking.

It is not safe to check base service state (IsRunning) while holding the lock
for the client state. If we do, then during shutdown we may deadlock with the
invocation of the OnStop handler, which the base service executes while holding
the service lock.

* Enqueue pending requests before sending them to the server.

If we don't do this, the server can reply before the request lands in the
queue.  That will cause the receiver to terminate early for an unsolicited
response. So enqueue first: This is safe because we're doing it in the same
routine as services the channel, so we won't take another message till we are
safely past that point.

* Document what we did.
* Fix socket paths in tests.

2022-05-19 12:11:57 -07:00

..

mocks

abci/client: remove lingering async client code (#7876)

2022-02-18 23:29:57 +00:00

client_test.go

Fix lock sequencing in socket client request tracking. (#8581)

2022-05-19 12:11:57 -07:00

client.go

abci: interface should take pointers to arguments (#8404)

2022-04-24 18:37:07 +00:00

metrics.gen.go

metrics: transition all metrics to using metricsgen generated constructors. (#8488)

2022-05-12 18:39:12 +00:00

metrics.go

metrics: transition all metrics to using metricsgen generated constructors. (#8488)

2022-05-12 18:39:12 +00:00

version.go

…