mirror of
https://github.com/tendermint/tendermint.git
synced 2026-01-06 21:36:26 +00:00
## What does this change do? This pull request completes the change to the `metricsgen` metrics. It adds `go generate` directives to all of the files containing the `Metrics` structs. Using the outputs of `metricsdiff` between these generated metrics and `master`, we can see that there is not a diff between the two sets of metrics when run locally. ``` [william@sidewinder] tendermint[wb/metrics-gen-transition]:. ◆ ./scripts/metricsgen/metricsdiff/metricsdiff metrics_master metrics_generated [william@sidewinder] tendermint[wb/metrics-gen-transition]:. ◆ ``` This change also adds parsing for a `metrics:` key in a field comment. If a comment line begins with `//metrics:` the rest of the line is interpreted to be the metric help text. Additionally, a bug where lists of labels were not properly quoted in the `metricsgen` rendered output was fixed.
21 lines
451 B
Go
21 lines
451 B
Go
package p2p
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/tendermint/tendermint/proto/tendermint/p2p"
|
|
)
|
|
|
|
func TestValueToMetricsLabel(t *testing.T) {
|
|
lc := newMetricsLabelCache()
|
|
r := &p2p.PexResponse{}
|
|
str := lc.ValueToMetricLabel(r)
|
|
assert.Equal(t, "p2p_PexResponse", str)
|
|
|
|
// subsequent calls to the function should produce the same result
|
|
str = lc.ValueToMetricLabel(r)
|
|
assert.Equal(t, "p2p_PexResponse", str)
|
|
}
|