mirror of
https://github.com/tendermint/tendermint.git
synced 2026-02-03 18:42:14 +00:00
cf7537ea5f
The code in the Tendermint repository makes heavy use of import aliasing. This is made necessary by our extensive reuse of common base package names, and by repetition of similar names across different subdirectories. Unfortunately we have not been very consistent about which packages we alias in various circumstances, and the aliases we use vary. In the spirit of the advice in the style guide and https://github.com/golang/go/wiki/CodeReviewComments#imports, his change makes an effort to clean up and normalize import aliasing. This change makes no API or behavioral changes. It is a pure cleanup intended o help make the code more readable to developers (including myself) trying to understand what is being imported where. Only unexported names have been modified, and the changes were generated and applied mechanically with gofmt -r and comby, respecting the lexical and syntactic rules of Go. Even so, I did not fix every inconsistency. Where the changes would be too disruptive, I left it alone. The principles I followed in this cleanup are: - Remove aliases that restate the package name. - Remove aliases where the base package name is unambiguous. - Move overly-terse abbreviations from the import to the usage site. - Fix lexical issues (remove underscores, remove capitalization). - Fix import groupings to more closely match the style guide. - Group blank (side-effecting) imports and ensure they are commented. - Add aliases to multiple imports with the same base package name.
78 lines
2.1 KiB
Go
78 lines
2.1 KiB
Go
package client_test
|
|
|
|
import (
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/tendermint/tendermint/rpc/client"
|
|
"github.com/tendermint/tendermint/rpc/client/mock"
|
|
"github.com/tendermint/tendermint/rpc/coretypes"
|
|
)
|
|
|
|
func TestWaitForHeight(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
|
|
// test with error result - immediate failure
|
|
m := &mock.StatusMock{
|
|
Call: mock.Call{
|
|
Error: errors.New("bye"),
|
|
},
|
|
}
|
|
r := mock.NewStatusRecorder(m)
|
|
|
|
// connection failure always leads to error
|
|
err := client.WaitForHeight(r, 8, nil)
|
|
require.NotNil(err)
|
|
require.Equal("bye", err.Error())
|
|
// we called status once to check
|
|
require.Equal(1, len(r.Calls))
|
|
|
|
// now set current block height to 10
|
|
m.Call = mock.Call{
|
|
Response: &coretypes.ResultStatus{SyncInfo: coretypes.SyncInfo{LatestBlockHeight: 10}},
|
|
}
|
|
|
|
// we will not wait for more than 10 blocks
|
|
err = client.WaitForHeight(r, 40, nil)
|
|
require.NotNil(err)
|
|
require.True(strings.Contains(err.Error(), "aborting"))
|
|
// we called status once more to check
|
|
require.Equal(2, len(r.Calls))
|
|
|
|
// waiting for the past returns immediately
|
|
err = client.WaitForHeight(r, 5, nil)
|
|
require.Nil(err)
|
|
// we called status once more to check
|
|
require.Equal(3, len(r.Calls))
|
|
|
|
// since we can't update in a background goroutine (test --race)
|
|
// we use the callback to update the status height
|
|
myWaiter := func(delta int64) error {
|
|
// update the height for the next call
|
|
m.Call.Response = &coretypes.ResultStatus{SyncInfo: coretypes.SyncInfo{LatestBlockHeight: 15}}
|
|
return client.DefaultWaitStrategy(delta)
|
|
}
|
|
|
|
// we wait for a few blocks
|
|
err = client.WaitForHeight(r, 12, myWaiter)
|
|
require.Nil(err)
|
|
// we called status once to check
|
|
require.Equal(5, len(r.Calls))
|
|
|
|
pre := r.Calls[3]
|
|
require.Nil(pre.Error)
|
|
prer, ok := pre.Response.(*coretypes.ResultStatus)
|
|
require.True(ok)
|
|
assert.Equal(int64(10), prer.SyncInfo.LatestBlockHeight)
|
|
|
|
post := r.Calls[4]
|
|
require.Nil(post.Error)
|
|
postr, ok := post.Response.(*coretypes.ResultStatus)
|
|
require.True(ok)
|
|
assert.Equal(int64(15), postr.SyncInfo.LatestBlockHeight)
|
|
}
|