mirror of
https://github.com/tendermint/tendermint.git
synced 2026-02-04 11:02:06 +00:00
0b8a62c87b
This change set implements the most recent version of `FinalizeBlock`. # What does this change actually contain? * This change set is rather large but fear not! The majority of the files touched and changes are renaming `ResponseDeliverTx` to `ExecTxResult`. This should be a pretty inoffensive change since they're effectively the same type but with a different name. * The `execBlockOnProxyApp` was totally removed since it served as just a wrapper around the logic that is now mostly encapsulated within `FinalizeBlock` * The `updateState` helper function has been made a public method on `State`. It was being exposed as a shim through the testing infrastructure, so this seemed innocuous. * Tests already existed to ensure that the application received the `ByzantineValidators` and the `ValidatorUpdates`, but one was fixed up to ensure that `LastCommitInfo` was being sent across. * Tests were removed from the `psql` indexer that seemed to search for an event in the indexer that was not being created. # Questions for reviewers * We store this [ABCIResponses](5721a13ab1/proto/tendermint/state/types.pb.go (L37)) type in the data base as the block results. This type has changed since v0.35 to contain the `FinalizeBlock` response. I'm wondering if we need to do any shimming to keep the old data retrieveable? * Similarly, this change is exposed via the RPC through [ResultBlockResults](5721a13ab1/rpc/coretypes/responses.go (L69)) changing. Should we somehow shim or notify for this change? closes: #7658
91 lines
2.7 KiB
Go
91 lines
2.7 KiB
Go
package testsuite
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
mrand "math/rand"
|
|
|
|
abciclient "github.com/tendermint/tendermint/abci/client"
|
|
"github.com/tendermint/tendermint/abci/types"
|
|
tmrand "github.com/tendermint/tendermint/libs/rand"
|
|
)
|
|
|
|
func InitChain(ctx context.Context, client abciclient.Client) error {
|
|
total := 10
|
|
vals := make([]types.ValidatorUpdate, total)
|
|
for i := 0; i < total; i++ {
|
|
pubkey := tmrand.Bytes(33)
|
|
// nolint:gosec // G404: Use of weak random number generator
|
|
power := mrand.Int()
|
|
vals[i] = types.UpdateValidator(pubkey, int64(power), "")
|
|
}
|
|
_, err := client.InitChain(ctx, types.RequestInitChain{
|
|
Validators: vals,
|
|
})
|
|
if err != nil {
|
|
fmt.Printf("Failed test: InitChain - %v\n", err)
|
|
return err
|
|
}
|
|
fmt.Println("Passed test: InitChain")
|
|
return nil
|
|
}
|
|
|
|
func Commit(ctx context.Context, client abciclient.Client, hashExp []byte) error {
|
|
res, err := client.Commit(ctx)
|
|
data := res.Data
|
|
if err != nil {
|
|
fmt.Println("Failed test: Commit")
|
|
fmt.Printf("error while committing: %v\n", err)
|
|
return err
|
|
}
|
|
if !bytes.Equal(data, hashExp) {
|
|
fmt.Println("Failed test: Commit")
|
|
fmt.Printf("Commit hash was unexpected. Got %X expected %X\n", data, hashExp)
|
|
return errors.New("commitTx failed")
|
|
}
|
|
fmt.Println("Passed test: Commit")
|
|
return nil
|
|
}
|
|
|
|
func FinalizeBlock(ctx context.Context, client abciclient.Client, txBytes [][]byte, codeExp []uint32, dataExp []byte) error {
|
|
res, _ := client.FinalizeBlock(ctx, types.RequestFinalizeBlock{Txs: txBytes})
|
|
for i, tx := range res.TxResults {
|
|
code, data, log := tx.Code, tx.Data, tx.Log
|
|
if code != codeExp[i] {
|
|
fmt.Println("Failed test: FinalizeBlock")
|
|
fmt.Printf("FinalizeBlock response code was unexpected. Got %v expected %v. Log: %v\n",
|
|
code, codeExp, log)
|
|
return errors.New("FinalizeBlock error")
|
|
}
|
|
if !bytes.Equal(data, dataExp) {
|
|
fmt.Println("Failed test: FinalizeBlock")
|
|
fmt.Printf("FinalizeBlock response data was unexpected. Got %X expected %X\n",
|
|
data, dataExp)
|
|
return errors.New("FinalizeBlock error")
|
|
}
|
|
}
|
|
fmt.Println("Passed test: FinalizeBlock")
|
|
return nil
|
|
}
|
|
|
|
func CheckTx(ctx context.Context, client abciclient.Client, txBytes []byte, codeExp uint32, dataExp []byte) error {
|
|
res, _ := client.CheckTx(ctx, types.RequestCheckTx{Tx: txBytes})
|
|
code, data, log := res.Code, res.Data, res.Log
|
|
if code != codeExp {
|
|
fmt.Println("Failed test: CheckTx")
|
|
fmt.Printf("CheckTx response code was unexpected. Got %v expected %v. Log: %v\n",
|
|
code, codeExp, log)
|
|
return errors.New("checkTx")
|
|
}
|
|
if !bytes.Equal(data, dataExp) {
|
|
fmt.Println("Failed test: CheckTx")
|
|
fmt.Printf("CheckTx response data was unexpected. Got %X expected %X\n",
|
|
data, dataExp)
|
|
return errors.New("checkTx")
|
|
}
|
|
fmt.Println("Passed test: CheckTx")
|
|
return nil
|
|
}
|