mirror of
https://github.com/tendermint/tendermint.git
synced 2026-02-10 05:50:19 +00:00
d7606777cf
This is a very small change, but removes a method from the `service.Service` interface (a win!) and forces callers to explicitly pass loggers in to objects during construction rather than (later) injecting them. There's not a real need for this kind of lazy construction of loggers, and I think a decent potential for confusion for mutable loggers. The main concern I have is that this changes the constructor API for ABCI clients. I think this is fine, and I suspect that as we plumb contexts through, and make changes to the RPC services there'll be a number of similar sorts of changes to various (quasi) public interfaces, which I think we should welcome.
31 lines
890 B
Go
31 lines
890 B
Go
package tests
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
abciclientent "github.com/tendermint/tendermint/abci/client"
|
|
"github.com/tendermint/tendermint/abci/example/kvstore"
|
|
abciserver "github.com/tendermint/tendermint/abci/server"
|
|
"github.com/tendermint/tendermint/libs/log"
|
|
)
|
|
|
|
func TestClientServerNoAddrPrefix(t *testing.T) {
|
|
addr := "localhost:26658"
|
|
transport := "socket"
|
|
app := kvstore.NewApplication()
|
|
|
|
logger := log.TestingLogger()
|
|
|
|
server, err := abciserver.NewServer(logger, addr, transport, app)
|
|
assert.NoError(t, err, "expected no error on NewServer")
|
|
err = server.Start()
|
|
assert.NoError(t, err, "expected no error on server.Start")
|
|
|
|
client, err := abciclientent.NewClient(logger, addr, transport, true)
|
|
assert.NoError(t, err, "expected no error on NewClient")
|
|
err = client.Start()
|
|
assert.NoError(t, err, "expected no error on client.Start")
|
|
}
|