mirror of
https://github.com/tendermint/tendermint.git
synced 2026-02-11 22:31:09 +00:00
0b8a62c87b
This change set implements the most recent version of `FinalizeBlock`. # What does this change actually contain? * This change set is rather large but fear not! The majority of the files touched and changes are renaming `ResponseDeliverTx` to `ExecTxResult`. This should be a pretty inoffensive change since they're effectively the same type but with a different name. * The `execBlockOnProxyApp` was totally removed since it served as just a wrapper around the logic that is now mostly encapsulated within `FinalizeBlock` * The `updateState` helper function has been made a public method on `State`. It was being exposed as a shim through the testing infrastructure, so this seemed innocuous. * Tests already existed to ensure that the application received the `ByzantineValidators` and the `ValidatorUpdates`, but one was fixed up to ensure that `LastCommitInfo` was being sent across. * Tests were removed from the `psql` indexer that seemed to search for an event in the indexer that was not being created. # Questions for reviewers * We store this [ABCIResponses](5721a13ab1/proto/tendermint/state/types.pb.go (L37)) type in the data base as the block results. This type has changed since v0.35 to contain the `FinalizeBlock` response. I'm wondering if we need to do any shimming to keep the old data retrieveable? * Similarly, this change is exposed via the RPC through [ResultBlockResults](5721a13ab1/rpc/coretypes/responses.go (L69)) changing. Should we somehow shim or notify for this change? closes: #7658
67 lines
2.1 KiB
Go
67 lines
2.1 KiB
Go
package indexer
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
"github.com/tendermint/tendermint/internal/pubsub/query"
|
|
"github.com/tendermint/tendermint/types"
|
|
)
|
|
|
|
// TxIndexer interface defines methods to index and search transactions.
|
|
type TxIndexer interface {
|
|
// Index analyzes, indexes and stores transactions. For indexing multiple
|
|
// Transacions must guarantee the Index of the TxResult is in order.
|
|
// See Batch struct.
|
|
Index(results []*abci.TxResult) error
|
|
|
|
// Get returns the transaction specified by hash or nil if the transaction is not indexed
|
|
// or stored.
|
|
Get(hash []byte) (*abci.TxResult, error)
|
|
|
|
// Search allows you to query for transactions.
|
|
Search(ctx context.Context, q *query.Query) ([]*abci.TxResult, error)
|
|
}
|
|
|
|
// BlockIndexer defines an interface contract for indexing block events.
|
|
type BlockIndexer interface {
|
|
// Has returns true if the given height has been indexed. An error is returned
|
|
// upon database query failure.
|
|
Has(height int64) (bool, error)
|
|
|
|
// Index indexes FinalizeBlock events for a given block by its height.
|
|
Index(types.EventDataNewBlockHeader) error
|
|
|
|
// Search performs a query for block heights that match a given FinalizeBlock
|
|
// event search criteria.
|
|
Search(ctx context.Context, q *query.Query) ([]int64, error)
|
|
}
|
|
|
|
// Batch groups together multiple Index operations to be performed at the same time.
|
|
// NOTE: Batch is NOT thread-safe and must not be modified after starting its execution.
|
|
type Batch struct {
|
|
Ops []*abci.TxResult
|
|
Pending int64
|
|
}
|
|
|
|
// NewBatch creates a new Batch.
|
|
func NewBatch(n int64) *Batch {
|
|
return &Batch{Ops: make([]*abci.TxResult, n), Pending: n}
|
|
}
|
|
|
|
// Add or update an entry for the given result.Index.
|
|
func (b *Batch) Add(result *abci.TxResult) error {
|
|
if b.Ops[result.Index] == nil {
|
|
b.Pending--
|
|
b.Ops[result.Index] = result
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Size returns the total number of operations inside the batch.
|
|
func (b *Batch) Size() int { return len(b.Ops) }
|
|
|
|
// ErrorEmptyHash indicates empty hash
|
|
var ErrorEmptyHash = errors.New("transaction hash cannot be empty")
|