mirror of
https://github.com/tendermint/tendermint.git
synced 2026-02-06 03:50:46 +00:00
e13b4386ff
`abci.Client`:
- Sync and Async methods now accept a context for cancellation
* grpc client uses context to cancel both Sync and Async requests
* local client ignores context parameter
* socket client uses context to cancel Sync requests and to drop Async requests before sending them if context was cancelled prior to that
- Async methods return an error
* socket client returns an error immediately if queue is full for Async requests
* local client always returns nil error
* grpc client returns an error if context was cancelled before we got response or the receiving queue had a space for response (do not confuse with the sending queue from the socket client)
- specify clients semantics in [doc.go](https://raw.githubusercontent.com/tendermint/tendermint/27112fffa62276bc016d56741f686f0f77931748/abci/client/doc.go)
`mempool.TxInfo`
- add optional `Context` to `TxInfo`, which can be used to cancel `CheckTx` request
Closes #5190
127 lines
2.8 KiB
Go
127 lines
2.8 KiB
Go
package abcicli_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
abcicli "github.com/tendermint/tendermint/abci/client"
|
|
"github.com/tendermint/tendermint/abci/server"
|
|
"github.com/tendermint/tendermint/abci/types"
|
|
tmrand "github.com/tendermint/tendermint/libs/rand"
|
|
"github.com/tendermint/tendermint/libs/service"
|
|
)
|
|
|
|
var ctx = context.Background()
|
|
|
|
func TestProperSyncCalls(t *testing.T) {
|
|
app := slowApp{}
|
|
|
|
s, c := setupClientServer(t, app)
|
|
t.Cleanup(func() {
|
|
if err := s.Stop(); err != nil {
|
|
t.Error(err)
|
|
}
|
|
})
|
|
t.Cleanup(func() {
|
|
if err := c.Stop(); err != nil {
|
|
t.Error(err)
|
|
}
|
|
})
|
|
|
|
resp := make(chan error, 1)
|
|
go func() {
|
|
// This is BeginBlockSync unrolled....
|
|
reqres, err := c.BeginBlockAsync(ctx, types.RequestBeginBlock{})
|
|
assert.NoError(t, err)
|
|
err = c.FlushSync(context.Background())
|
|
assert.NoError(t, err)
|
|
res := reqres.Response.GetBeginBlock()
|
|
assert.NotNil(t, res)
|
|
resp <- c.Error()
|
|
}()
|
|
|
|
select {
|
|
case <-time.After(time.Second):
|
|
require.Fail(t, "No response arrived")
|
|
case err, ok := <-resp:
|
|
require.True(t, ok, "Must not close channel")
|
|
assert.NoError(t, err, "This should return success")
|
|
}
|
|
}
|
|
|
|
func TestHangingSyncCalls(t *testing.T) {
|
|
app := slowApp{}
|
|
|
|
s, c := setupClientServer(t, app)
|
|
t.Cleanup(func() {
|
|
if err := s.Stop(); err != nil {
|
|
t.Log(err)
|
|
}
|
|
})
|
|
t.Cleanup(func() {
|
|
if err := c.Stop(); err != nil {
|
|
t.Log(err)
|
|
}
|
|
})
|
|
|
|
resp := make(chan error, 1)
|
|
go func() {
|
|
// Start BeginBlock and flush it
|
|
reqres, err := c.BeginBlockAsync(ctx, types.RequestBeginBlock{})
|
|
assert.NoError(t, err)
|
|
flush, err := c.FlushAsync(ctx)
|
|
assert.NoError(t, err)
|
|
// wait 20 ms for all events to travel socket, but
|
|
// no response yet from server
|
|
time.Sleep(20 * time.Millisecond)
|
|
// kill the server, so the connections break
|
|
err = s.Stop()
|
|
assert.NoError(t, err)
|
|
|
|
// wait for the response from BeginBlock
|
|
reqres.Wait()
|
|
flush.Wait()
|
|
resp <- c.Error()
|
|
}()
|
|
|
|
select {
|
|
case <-time.After(time.Second):
|
|
require.Fail(t, "No response arrived")
|
|
case err, ok := <-resp:
|
|
require.True(t, ok, "Must not close channel")
|
|
assert.Error(t, err, "We should get EOF error")
|
|
}
|
|
}
|
|
|
|
func setupClientServer(t *testing.T, app types.Application) (
|
|
service.Service, abcicli.Client) {
|
|
// some port between 20k and 30k
|
|
port := 20000 + tmrand.Int32()%10000
|
|
addr := fmt.Sprintf("localhost:%d", port)
|
|
|
|
s, err := server.NewServer(addr, "socket", app)
|
|
require.NoError(t, err)
|
|
err = s.Start()
|
|
require.NoError(t, err)
|
|
|
|
c := abcicli.NewSocketClient(addr, true)
|
|
err = c.Start()
|
|
require.NoError(t, err)
|
|
|
|
return s, c
|
|
}
|
|
|
|
type slowApp struct {
|
|
types.BaseApplication
|
|
}
|
|
|
|
func (slowApp) BeginBlock(req types.RequestBeginBlock) types.ResponseBeginBlock {
|
|
time.Sleep(200 * time.Millisecond)
|
|
return types.ResponseBeginBlock{}
|
|
}
|