tendermint

mirror of https://github.com/tendermint/tendermint.git synced 2026-07-21 07:22:20 +00:00

Files

T

Dev Ojha cdba0d82f5 p2p: ensure peers can't change IP of known nodes (#5136 )

Closes #1581 

This fixes the error in #1581, and also documents the purpose of this line. It ensures that if a peer tells us an address we know about, whose ID is the same as our current ID, we ignore it.

This removes the previous case where the ID's matched, but the IP's did not, which could yield a potential overwrite of the IP associated with the address later on. (This then would yield an eclipse attack)

This was not a vulnerability before though, thanks to a defensive check here https://github.com/tendermint/tendermint/blob/95fc7e58eedd3b0a563b93a0691c9cbe6e10f017/p2p/pex/addrbook.go#L522)

2020-07-22 09:56:38 +04:00

addrbook_test.go

p2p: ensure peers can't change IP of known nodes (#5136 )

2020-07-22 09:56:38 +04:00

addrbook.go

p2p: ensure peers can't change IP of known nodes (#5136 )

2020-07-22 09:56:38 +04:00

errors.go

p2p: ensure peers can't change IP of known nodes (#5136 )

2020-07-22 09:56:38 +04:00

file.go

linter: (1/2) enable errcheck (#5064 )