tendermint

mirror of https://github.com/tendermint/tendermint.git synced 2026-01-08 22:23:11 +00:00

Files

zjubfd 5a25b75b1d p2p: refactor GetSelectionWithBias for addressbook (#3475 )

Why submit this pr:

    we have suffered from infinite loop in addrbook bug which takes us a long time to find out why process become a zombie peer. It have been fixed in #3232. But the ADDRS_LOOP is still there, risk of infinite loop is still exist.
    The algorithm that to random pick a bucket is not stable, which means the peer may unluckily always choose the wrong bucket for a long time, the time and cpu cost is meaningless.

A simple improvement:
shuffle bucketsNew and bucketsOld, and pick necessary number of address from them. A stable
algorithm.

2019-03-26 17:13:14 +01:00

addrbook_test.go

p2p: refactor GetSelectionWithBias for addressbook (#3475 )

2019-03-26 17:13:14 +01:00

addrbook.go

p2p: refactor GetSelectionWithBias for addressbook (#3475 )

2019-03-26 17:13:14 +01:00

errors.go

p2p: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode (#2797 )

2018-11-11 06:50:25 -05:00

file.go

libs: Remove usage of custom Fmt, in favor of fmt.Sprintf (#2199 )