mirror of
https://github.com/tendermint/tendermint.git
synced 2026-01-07 13:55:17 +00:00
0b8a62c87b
This change set implements the most recent version of `FinalizeBlock`. # What does this change actually contain? * This change set is rather large but fear not! The majority of the files touched and changes are renaming `ResponseDeliverTx` to `ExecTxResult`. This should be a pretty inoffensive change since they're effectively the same type but with a different name. * The `execBlockOnProxyApp` was totally removed since it served as just a wrapper around the logic that is now mostly encapsulated within `FinalizeBlock` * The `updateState` helper function has been made a public method on `State`. It was being exposed as a shim through the testing infrastructure, so this seemed innocuous. * Tests already existed to ensure that the application received the `ByzantineValidators` and the `ValidatorUpdates`, but one was fixed up to ensure that `LastCommitInfo` was being sent across. * Tests were removed from the `psql` indexer that seemed to search for an event in the indexer that was not being created. # Questions for reviewers * We store this [ABCIResponses](5721a13ab1/proto/tendermint/state/types.pb.go (L37)) type in the data base as the block results. This type has changed since v0.35 to contain the `FinalizeBlock` response. I'm wondering if we need to do any shimming to keep the old data retrieveable? * Similarly, this change is exposed via the RPC through [ResultBlockResults](5721a13ab1/rpc/coretypes/responses.go (L69)) changing. Should we somehow shim or notify for this change? closes: #7658
121 lines
3.2 KiB
Go
121 lines
3.2 KiB
Go
package core
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
dbm "github.com/tendermint/tm-db"
|
|
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
sm "github.com/tendermint/tendermint/internal/state"
|
|
"github.com/tendermint/tendermint/internal/state/mocks"
|
|
tmstate "github.com/tendermint/tendermint/proto/tendermint/state"
|
|
"github.com/tendermint/tendermint/rpc/coretypes"
|
|
)
|
|
|
|
func TestBlockchainInfo(t *testing.T) {
|
|
cases := []struct {
|
|
min, max int64
|
|
base, height int64
|
|
limit int64
|
|
resultLength int64
|
|
wantErr bool
|
|
}{
|
|
|
|
// min > max
|
|
{0, 0, 0, 0, 10, 0, true}, // min set to 1
|
|
{0, 1, 0, 0, 10, 0, true}, // max set to height (0)
|
|
{0, 0, 0, 1, 10, 1, false}, // max set to height (1)
|
|
{2, 0, 0, 1, 10, 0, true}, // max set to height (1)
|
|
{2, 1, 0, 5, 10, 0, true},
|
|
|
|
// negative
|
|
{1, 10, 0, 14, 10, 10, false}, // control
|
|
{-1, 10, 0, 14, 10, 0, true},
|
|
{1, -10, 0, 14, 10, 0, true},
|
|
{-9223372036854775808, -9223372036854775788, 0, 100, 20, 0, true},
|
|
|
|
// check base
|
|
{1, 1, 1, 1, 1, 1, false},
|
|
{2, 5, 3, 5, 5, 3, false},
|
|
|
|
// check limit and height
|
|
{1, 1, 0, 1, 10, 1, false},
|
|
{1, 1, 0, 5, 10, 1, false},
|
|
{2, 2, 0, 5, 10, 1, false},
|
|
{1, 2, 0, 5, 10, 2, false},
|
|
{1, 5, 0, 1, 10, 1, false},
|
|
{1, 5, 0, 10, 10, 5, false},
|
|
{1, 15, 0, 10, 10, 10, false},
|
|
{1, 15, 0, 15, 10, 10, false},
|
|
{1, 15, 0, 15, 20, 15, false},
|
|
{1, 20, 0, 15, 20, 15, false},
|
|
{1, 20, 0, 20, 20, 20, false},
|
|
}
|
|
|
|
for i, c := range cases {
|
|
caseString := fmt.Sprintf("test %d failed", i)
|
|
min, max, err := filterMinMax(c.base, c.height, c.min, c.max, c.limit)
|
|
if c.wantErr {
|
|
require.Error(t, err, caseString)
|
|
} else {
|
|
require.NoError(t, err, caseString)
|
|
require.Equal(t, 1+max-min, c.resultLength, caseString)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBlockResults(t *testing.T) {
|
|
results := &tmstate.ABCIResponses{
|
|
FinalizeBlock: &abci.ResponseFinalizeBlock{
|
|
TxResults: []*abci.ExecTxResult{
|
|
{Code: 0, Data: []byte{0x01}, Log: "ok", GasUsed: 10},
|
|
{Code: 0, Data: []byte{0x02}, Log: "ok", GasUsed: 5},
|
|
{Code: 1, Log: "not ok", GasUsed: 0},
|
|
},
|
|
},
|
|
}
|
|
|
|
env := &Environment{}
|
|
env.StateStore = sm.NewStore(dbm.NewMemDB())
|
|
err := env.StateStore.SaveABCIResponses(100, results)
|
|
require.NoError(t, err)
|
|
mockstore := &mocks.BlockStore{}
|
|
mockstore.On("Height").Return(int64(100))
|
|
mockstore.On("Base").Return(int64(1))
|
|
env.BlockStore = mockstore
|
|
|
|
testCases := []struct {
|
|
height int64
|
|
wantErr bool
|
|
wantRes *coretypes.ResultBlockResults
|
|
}{
|
|
{-1, true, nil},
|
|
{0, true, nil},
|
|
{101, true, nil},
|
|
{100, false, &coretypes.ResultBlockResults{
|
|
Height: 100,
|
|
TxsResults: results.FinalizeBlock.TxResults,
|
|
TotalGasUsed: 15,
|
|
FinalizeBlockEvents: results.FinalizeBlock.Events,
|
|
ValidatorUpdates: results.FinalizeBlock.ValidatorUpdates,
|
|
ConsensusParamUpdates: results.FinalizeBlock.ConsensusParamUpdates,
|
|
}},
|
|
}
|
|
|
|
ctx := context.Background()
|
|
for _, tc := range testCases {
|
|
res, err := env.BlockResults(ctx, &tc.height)
|
|
if tc.wantErr {
|
|
assert.Error(t, err)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, tc.wantRes, res)
|
|
}
|
|
}
|
|
}
|