mirror of https://github.com/tendermint/tendermint.git synced 2026-01-05 13:05:09 +00:00

Files

William Banfield da204d371d consensus: correctly save reference to previous height precommits (#9760 )

This change reduces the number of Precommit messages sent to peers by 50%. 

During the `ApplyNewRoundStepMessage`, we update the known state of the peer sending us the message.

We set the value of `ps.PRS.Precommits` to nil in this method if the peer is entering a new height or round.
34ca3fb474/consensus/reactor.go (L1368)

We then assign `ps.PRS.LastCommit = ps.PRS.Precommits` if the peer is entering a new height only - this does not happen during just a round change. This therefore results in `ps.PRS.LastCommit` having the value `nil`. 

When the `LastCommit` bit field is seen as `nil` in the reactor, an empty bit field is initialized.
34ca3fb474/consensus/reactor.go (L1273)

The code responsible for gossiping votes from the previous height uses this `LastCommit` value and, seeing an empty `LastCommit` will resend every `Precommit` from the previous height since it lost the information it previously had detailing which precommits from the previous height the peer had.

This can be seen in the code responsible for gossiping precommits from the previous height:
34ca3fb474/consensus/reactor.go (L773)

Where this code grabs the, previously `nil`, `LastCommit` bit field:
34ca3fb474/consensus/reactor.go (L1204-L1212)

---

#### PR checklist

- [ ] Tests written/updated, or no tests needed
- [ ] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [ ] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed

2022-11-28 20:13:14 +00:00

types

config: cleaner separation of tests (#9421 )

2022-09-22 12:42:25 +02:00

byzantine_test.go

p2p: add a per-message type send and receive metric (#9622 )

2022-10-27 15:46:15 -04:00

common_test.go

config: cleaner separation of tests (#9421 )

2022-09-22 12:42:25 +02:00

invalid_test.go

p2p: add a per-message type send and receive metric (#9622 )