Thane Thomson d69bd64702 abci++: Vote extension cleanup (#8402) ...

* Split vote verification/validation based on vote extensions

Some parts of the code need vote extensions to be verified and
validated (mostly in consensus), and other parts of the code don't
because its possible that, in some cases (as per RFC 017), we won't have
vote extensions.

This explicitly facilitates that split.

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Only sign extensions in precommits, not prevotes

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update privval/file.go

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>

* Apply suggestions from code review

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>

* Temporarily disable extension requirement again for E2E testing

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Reorganize comment for clarity

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Leave vote validation and pre-call nil check up to caller of VoteToProto

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Split complex vote validation test into multiple tests

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Universally enforce no vote extensions on any vote type but precommits

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Make error messages more generic

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Verify with vote extensions when constructing a VoteSet

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Expand comment for clarity

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add extension check for prevotes prior to signing votes

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix supporting test code to only inject extensions into precommits

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Separate vote malleation from signing in vote tests for clarity

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add extension signature length check and corresponding test

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Perform basic vote validation in CommitToVoteSet

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>

2022-04-28 13:53:44 -04:00

..

block_meta_test.go

state sync: reverse sync implementation (#6463)

2021-06-08 19:23:52 +02:00

block_meta.go

types: add string format to 64-bit integer JSON fields (#7787)

2022-02-09 13:34:23 +00:00

block_test.go

abci++: Sync implementation and spec for vote extensions (#8141)

2022-04-19 08:05:17 -04:00

block.go

abci++: Vote extension cleanup (#8402)

2022-04-28 13:53:44 -04:00

canonical_test.go

proto: folder structure adhere to buf (#5025)

2020-06-22 10:00:51 +02:00

canonical.go

abci++: Sync implementation and spec for vote extensions (#8141)

2022-04-19 08:05:17 -04:00

encoding_helper.go

proto: leftover amino (#4986)

2020-06-15 11:14:36 +02:00

errors_p2p.go

p2p: make NodeID and NetAddress public (#6583)

2021-06-24 09:59:14 -04:00

errors.go

types: change Commit to consist of just signatures (#4146)

2019-11-26 14:10:38 +04:00

events_test.go

rpc: implement the ADR 075 /events method (#7965)

2022-02-23 15:22:40 -08:00

events.go

eventbus: publish without contexts (#8369)

2022-04-18 16:28:31 -04:00

evidence_test.go

cleanup: unused parameters (#8372)

2022-04-18 16:45:21 -04:00

evidence.go

abci++: Vote extension cleanup (#8402)

2022-04-28 13:53:44 -04:00

genesis_test.go

types: add TimeoutParams into ConsensusParams structs (#8177)

2022-03-22 11:19:54 -04:00

genesis.go

types: add default values for the synchrony parameters (#7788)

2022-02-19 19:53:18 +00:00

light_test.go

types: tests should not panic (#7506)

2022-01-05 14:21:40 -05:00

light.go

light: return light client status on rpc /status (#7536)

2022-01-20 14:53:20 +01:00

mempool.go

mempool,rpc: add removetx rpc method (#7047)

2021-10-05 20:23:15 +00:00

node_id.go

p2p, types: remove legacy NetAddress type (#7084)

2021-10-08 12:29:20 -04:00

node_info_test.go

spec: merge spec repo into tendermint repo (#7804)

2022-02-17 13:02:48 +01:00

node_info.go

spec: merge spec repo into tendermint repo (#7804)

2022-02-17 13:02:48 +01:00

node_key_test.go

testing: pass testing.T to assert and require always, assertion cleanup (#7508)

2022-01-05 09:25:08 -05:00

node_key.go

rpc: use encoding/json rather than tmjson (#7670)

2022-01-21 15:10:28 -08:00

params_test.go

consensus: timeout params in toml used as overrides (#8186)

2022-03-28 17:33:23 -04:00

params.go

crypto: remove unused code (#8412)

2022-04-25 12:35:59 -04:00

part_set_test.go

testing: pass testing.T to assert and require always, assertion cleanup (#7508)

2022-01-05 09:25:08 -05:00

part_set.go

Replace uses of libs/json with encoding/json. (#7534)

2022-01-08 08:47:26 -08:00

priv_validator.go

abci++: Vote extension cleanup (#8402)

2022-04-28 13:53:44 -04:00

proposal_test.go

types: make timely predicate adaptive after 10 rounds (#7739)

2022-02-02 15:25:04 +00:00

proposal.go

spec: merge spec repo into tendermint repo (#7804)

2022-02-17 13:02:48 +01:00

protobuf_test.go

cleanup: unused parameters (#8372)

2022-04-18 16:45:21 -04:00

protobuf.go

cleanup: Reduce and normalize import path aliasing. (#6975)

2021-09-23 07:52:07 -07:00

signable.go

types: minor cleanup of un or minimally used types (#8154)

2022-03-18 16:27:10 +00:00

signed_msg_type.go

proto: folder structure adhere to buf (#5025)

2020-06-22 10:00:51 +02:00

test_util.go

abci++: Sync implementation and spec for vote extensions (#8141)

2022-04-19 08:05:17 -04:00

tx_test.go

abci++: correct max-size check to only operate on added and unmodified (#8242)

2022-04-01 17:44:38 -04:00

tx.go

Remove ModifiedTxStatus from the spec and the code (#8210)

2022-04-04 12:43:01 +02:00

utils.go

libs/common: refactor libs common 3 (#4232)

2019-12-11 09:31:25 +01:00

validation_test.go

types: tests should not panic (#7506)

2022-01-05 14:21:40 -05:00

validation.go

abci: Synchronize FinalizeBlock with the updated specification (#7983)

2022-03-04 22:32:37 +00:00

validator_set_test.go

types: tests should not panic (#7506)

2022-01-05 14:21:40 -05:00

validator_set.go

statesync+blocksync: move event publications into the sync operations (#8274)

2022-04-07 16:23:36 -04:00

validator_test.go

spec: merge spec repo into tendermint repo (#7804)

2022-02-17 13:02:48 +01:00

validator.go

rpc: use encoding/json rather than tmjson (#7670)

2022-01-21 15:10:28 -08:00

vote_set_test.go

abci++: Sync implementation and spec for vote extensions (#8141)

2022-04-19 08:05:17 -04:00

vote_set.go

abci++: Vote extension cleanup (#8402)

2022-04-28 13:53:44 -04:00

vote_test.go

abci++: Vote extension cleanup (#8402)

2022-04-28 13:53:44 -04:00

vote.go

abci++: Vote extension cleanup (#8402)

2022-04-28 13:53:44 -04:00