mirror of
https://github.com/tendermint/tendermint.git
synced 2026-01-08 22:23:11 +00:00
da1b871808
Pass all parameters from JSON-RPC requests to their corresponding handlers using struct types instead of positional parameters. This allows us to control encoding of arguments using only the standard library, and to eliminate the remaining special-purpose JSON encoding hooks in the server. To support existing use, the server still allows arguments to be encoded in JSON as either an array or an object. Related changes: - Rework the RPCFunc constructor to reduce reflection during RPC call service. - Add request parameter wrappers for each RPC service method. - Update the RPC Environment methods to use these types. - Update the interfaces and shims derived from Environment to the new signatures. - Update and extend test cases.
123 lines
3.2 KiB
Go
123 lines
3.2 KiB
Go
package core
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
dbm "github.com/tendermint/tm-db"
|
|
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
sm "github.com/tendermint/tendermint/internal/state"
|
|
"github.com/tendermint/tendermint/internal/state/mocks"
|
|
tmstate "github.com/tendermint/tendermint/proto/tendermint/state"
|
|
"github.com/tendermint/tendermint/rpc/coretypes"
|
|
)
|
|
|
|
func TestBlockchainInfo(t *testing.T) {
|
|
cases := []struct {
|
|
min, max int64
|
|
base, height int64
|
|
limit int64
|
|
resultLength int64
|
|
wantErr bool
|
|
}{
|
|
|
|
// min > max
|
|
{0, 0, 0, 0, 10, 0, true}, // min set to 1
|
|
{0, 1, 0, 0, 10, 0, true}, // max set to height (0)
|
|
{0, 0, 0, 1, 10, 1, false}, // max set to height (1)
|
|
{2, 0, 0, 1, 10, 0, true}, // max set to height (1)
|
|
{2, 1, 0, 5, 10, 0, true},
|
|
|
|
// negative
|
|
{1, 10, 0, 14, 10, 10, false}, // control
|
|
{-1, 10, 0, 14, 10, 0, true},
|
|
{1, -10, 0, 14, 10, 0, true},
|
|
{-9223372036854775808, -9223372036854775788, 0, 100, 20, 0, true},
|
|
|
|
// check base
|
|
{1, 1, 1, 1, 1, 1, false},
|
|
{2, 5, 3, 5, 5, 3, false},
|
|
|
|
// check limit and height
|
|
{1, 1, 0, 1, 10, 1, false},
|
|
{1, 1, 0, 5, 10, 1, false},
|
|
{2, 2, 0, 5, 10, 1, false},
|
|
{1, 2, 0, 5, 10, 2, false},
|
|
{1, 5, 0, 1, 10, 1, false},
|
|
{1, 5, 0, 10, 10, 5, false},
|
|
{1, 15, 0, 10, 10, 10, false},
|
|
{1, 15, 0, 15, 10, 10, false},
|
|
{1, 15, 0, 15, 20, 15, false},
|
|
{1, 20, 0, 15, 20, 15, false},
|
|
{1, 20, 0, 20, 20, 20, false},
|
|
}
|
|
|
|
for i, c := range cases {
|
|
caseString := fmt.Sprintf("test %d failed", i)
|
|
min, max, err := filterMinMax(c.base, c.height, c.min, c.max, c.limit)
|
|
if c.wantErr {
|
|
require.Error(t, err, caseString)
|
|
} else {
|
|
require.NoError(t, err, caseString)
|
|
require.Equal(t, 1+max-min, c.resultLength, caseString)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBlockResults(t *testing.T) {
|
|
results := &tmstate.ABCIResponses{
|
|
FinalizeBlock: &abci.ResponseFinalizeBlock{
|
|
TxResults: []*abci.ExecTxResult{
|
|
{Code: 0, Data: []byte{0x01}, Log: "ok", GasUsed: 10},
|
|
{Code: 0, Data: []byte{0x02}, Log: "ok", GasUsed: 5},
|
|
{Code: 1, Log: "not ok", GasUsed: 0},
|
|
},
|
|
},
|
|
}
|
|
|
|
env := &Environment{}
|
|
env.StateStore = sm.NewStore(dbm.NewMemDB())
|
|
err := env.StateStore.SaveABCIResponses(100, results)
|
|
require.NoError(t, err)
|
|
mockstore := &mocks.BlockStore{}
|
|
mockstore.On("Height").Return(int64(100))
|
|
mockstore.On("Base").Return(int64(1))
|
|
env.BlockStore = mockstore
|
|
|
|
testCases := []struct {
|
|
height int64
|
|
wantErr bool
|
|
wantRes *coretypes.ResultBlockResults
|
|
}{
|
|
{-1, true, nil},
|
|
{0, true, nil},
|
|
{101, true, nil},
|
|
{100, false, &coretypes.ResultBlockResults{
|
|
Height: 100,
|
|
TxsResults: results.FinalizeBlock.TxResults,
|
|
TotalGasUsed: 15,
|
|
FinalizeBlockEvents: results.FinalizeBlock.Events,
|
|
ValidatorUpdates: results.FinalizeBlock.ValidatorUpdates,
|
|
ConsensusParamUpdates: results.FinalizeBlock.ConsensusParamUpdates,
|
|
}},
|
|
}
|
|
|
|
ctx := context.Background()
|
|
for _, tc := range testCases {
|
|
res, err := env.BlockResults(ctx, &coretypes.RequestBlockInfo{
|
|
Height: (*coretypes.Int64)(&tc.height),
|
|
})
|
|
if tc.wantErr {
|
|
assert.Error(t, err)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, tc.wantRes, res)
|
|
}
|
|
}
|
|
}
|